A job that ignores its cancellation token holds its worker forever

未关闭
#3,266 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
56/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
csharp

调研方向

Read src/FluentCMS.Core/Jobs/JobExecutor.cs around lines 101 and 213, then inspect JobTimeoutTests.AJobThatIgnoresItsTokenStopsBeingRenewedAndIsTakenOverWhenItsLeaseLapses and compare the hand-off behavior in OutboxDrainer. Trace how attempt timeout and grace are handled; done means the acceptance cases pass and abandoned invocations are counted by a metric.

由索引模型根据 Issue 内容生成。

描述

area:jobs type:bug

Problem

JobExecutor (src/FluentCMS.Core/Jobs/JobExecutor.cs:101,213) awaits the job's invocation directly. When the attempt timeout fires, the lease lapses and another worker takes the job, but the first worker stays in its await (see JobTimeoutTests.AJobThatIgnoresItsTokenStopsBeingRenewedAndIsTakenOverWhenItsLeaseLapses). Two such attempts stop the default queue (scheduled publish, retention, trash purge) on every instance until restart, and /health/ready reports Degraded only after 15 minutes. OutboxDrainer already hands off and waits with a limit.

Proposal

Run the invocation through a hand-off and WaitAsync(limit + grace); on time-out abandon it, settle the attempt as failed, free the worker, and count abandoned runs.

Acceptance

  • A job that ignores its token frees its worker after its limit plus grace
  • A metric counts abandoned invocations

Found in the code review of 17 Nov 2026 (B3).

主要语言
C#
星标
569
派生
107
平均合并
2 小时 49 分钟
30 天内合并 PR
397

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

fluentcms/FluentCMS 的其他 Issue

查看 fluentcms/FluentCMS 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。