Current Error Handling does not return false on logging errors
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 45/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- java
调研方向
从 RawSocketSender.java 第 204 行附近开始，跟踪连接失败和缓冲区空间耗尽这两种情况下的 log() 路径。重现 issue 中描述的两个失败案例，然后验证当任一内部操作失败时，log() 报告的是失败而不是成功。查看 issue #15 了解现有的错误处理上下文。
由索引模型根据 Issue 内容生成。
描述
There are two types of errors I've run into:
- Network Errors:
Here I created an app to log to a remote Fluentd instance.
private static final FluentLogger LOG = FluentLogger.getLogger("audit", "10.0.0.1", 22224);
However, I forgot to start the remote Fluentd instance before running the app, so I got Network Errors
java.net.ConnectException: Connection refused at java.net.PlainSocketImpl.socketConnect(Native Method) at java.net.AbstractPlainSocketImpl.doConnect(AbstractPlainSocketImpl.java:345) at java.net.AbstractPlainSocketImpl.connectToAddress(AbstractPlainSocketImpl.java:206) at java.net.AbstractPlainSocketImpl.connect(AbstractPlainSocketImpl.java:188) at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:392) at java.net.Socket.connect(Socket.java:589) at org.fluentd.logger.sender.RawSocketSender.connect(RawSocketSender.java:85) at org.fluentd.logger.sender.RawSocketSender.reconnect(RawSocketSender.java:98) at org.fluentd.logger.sender.RawSocketSender.flush(RawSocketSender.java:206) at org.fluentd.logger.sender.RawSocketSender.send(RawSocketSender.java:195) at org.fluentd.logger.sender.RawSocketSender.emit(RawSocketSender.java:157) at org.fluentd.logger.sender.RawSocketSender.emit(RawSocketSender.java:139) at org.fluentd.logger.sender.RawSocketSender.emit(RawSocketSender.java:134) at org.fluentd.logger.FluentLogger.log(FluentLogger.java:101) at org.fluentd.logger.FluentLogger.log(FluentLogger.java:86) at LoggerInfra.log(FluentdLoggerApp.java:27) at LoggerCaller.testLogger(FluentdLoggerApp.java:79) at FluentdLoggerApp.main(FluentdLoggerApp.java:112)
There error was printed to console (expected because of limited error handling #15), but the log() call returned true instead of false which hid the internal failure.
Result of logic in RawSocketSender.java#L204 which simple logs the error message to LOG.error().
- A second error is that I ran out of buffer space. In this setup I had my app logging to a local Fluentd instance and buffering to file. The local instance then forwards the logs to a remote instance. However the remote instance was not running, so the local buffer space eventually got filled up. Again the
log()call returned true and the stack trace was printed out to terminal.
- 主要语言
- Java
- 星标
- 210
- 派生
- 86
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
fluent/fluent-logger-java 的其他 Issue
-
难度 3/5 1-2 天 新手友好度 45/100
fluent/fluent-logger-java#100 ·
-
难度 4/5 3-5 天 新手友好度 15/100
fluent/fluent-logger-java#99 · 1 条评论 · 2 个 reaction ·
-
难度 3/5 1-2 天 新手友好度 45/100
fluent/fluent-logger-java#98 · 1 条评论 ·
-
Null Pointer Exception with slf4j-log4j12-1.7.30 (Fluent-logger incompatible with the new version)未关闭
难度 3/5 1-2 天 新手友好度 42/100
fluent/fluent-logger-java#89 · 3 条评论 ·
-
难度 3/5 1-2 天 新手友好度 25/100
fluent/fluent-logger-java#88 · 1 条评论 ·
查看 fluent/fluent-logger-java 的全部 Issue
相似的 Issue
-
`GET /v1/event/token/{uuid}` can report a BOM upload as done before policy evaluation and metrics have finished可能已有人在做 @Zargath 今天认领。 未关闭defect in triage
难度 2/5 1-3 小时 新手友好度 72/100
DependencyTrack/dependency-track#7646 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
objectionary/eo-graphs#80 ·
-
WebMvcStreamableServerTransportProvider: idle-session eviction stops permanently after a NullPointerException when a session is deleted mid-sweep可能已有人在做 @lejuho 今天认领。 未关闭status: waiting-for-triage
难度 2/5 1-3 小时 新手友好度 72/100
spring-projects/spring-ai#7133 ·
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
objectionary/jucs#141 ·
维护者通常 1 天内回复