use ratios instead of percentages in campaign mix

未关闭
#509 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
52/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
冷清
技术栈
rust
领域
backend

调研方向

从 issue 中链接的 campaign 定义开始,搜索 CampaignMixEntry、ResolvedMixEntry 和 share_pct,以找到所有受影响的入口点。跟踪 mix rate 的计算方式,然后验证基于比例的输入是否按描述分配 total rate,并始终使用无符号整数;issue 指出,舍入可能会留下少量余数。

由索引模型根据 Issue 内容生成。

描述

enhancement

Is your feature request related to a problem? Please describe.

Regarding campaign definitions, mix_pct (percentage) forces the user to manually sum up each mix's percentage to get the right ratio, which can be error-prone and tedious in campaigns with lots of mixes.

Describe the solution you'd like

Use ratios instead.

  • in CampaignMixEntry and ResolvedMixEntry, change share_pct to ratio
  • use unsigned ints instead of signed

Example:

mix_ratio_A = 2
mix_ratio_B = 1
total_tps = 100

Mix A would then produce 67 tps, and Mix B would produce 33, because A ≈ 2B.

Example:

mix_ratio_A = 1
mix_ratio_B = 1
mix_ratio_C = 1
mix_ratio_D = 1
total_tps = 100

Each mix would produce 25 tps.

Here's how I'd work out the final rate of each mix_ratio $\large m_i$ given total spam rate (tps/tpb) $\large t$:
$$\Large spamRate(m_i) = \frac{t * m_i}{\sum_{k=1}^n m_k}$$

or in code:

fn mix_spam_rate(ratio: u64, ratios: &[u64], total_rate: u64) -> u64 {
    (total_rate * ratio) / ratios.iter().sum::<u64>()
}

Using unsigned ints in this formula sometimes creates conditions where the sum of the individual rates doesn't meet the total desired rate (e.g. you get 99 tps instead of 100 because of a round-down), but it gets close enough.

Using floating point integers at the intake (CampaignMixEntry) could solve this (allowing us to round more intelligently before casting to unsigned) but not sure it's worth the effort. Users can always just increase the total_rate a little bit to compensate if they need to exactly hit the target spam rate.

主要语言
Rust
星标
144
派生
58
PR 合并指标
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

flashbots/contender 的其他 Issue

查看 flashbots/contender 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。