[FR] Update cmake/external/uWebSockets to version more recent than 2017
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 30/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- cmake, cpp
- 领域
- build-system
调研方向
从 cmake/external/uWebSockets.cmake 开始，将固定在 4d94401b 的依赖项与所引用的 uWebSockets 版本进行比较。然后检查 scripts/git/patches/uWebSockets/0001-fix-want-write-and-sprintf-deprecation.patch，以及所引用的 HTTPSocket.h 和 Socket.h 更改。完成的标准是选择一个受支持的更新版本，并针对由此产生的 API 更改更新依赖集成和补丁。
由索引模型根据 Issue 内容生成。
描述
Feature proposal
- Firebase Component: build (cmake/external/uWebSockets)
This SDK uses cmake/external/uWebSockets 4d94401b from 20170925 ~v0.14.4... which is VERY old!
https://github.com/firebase/firebase-cpp-sdk/blob/b4f9e0b45d9cf69688cdb0285627aedfcc906dd9/cmake/external/uWebSockets.cmake#L21
https://github.com/uNetworking/uWebSockets/tree/4d94401b9c98346f9afd838556fdc7dce30561eb
According to https://github.com/uNetworking/uWebSockets/releases?page=16, a 20170925 commit would place this code between releases v0.14.4 and v0.14.5.
The latest uWebSockets is v20.63.0.
The version is not as big of a jump as it may seem.
According to https://github.com/uNetworking/uWebSockets/releases?page=11, release 0.17.6 was followed by 18.0.0, so I think they just dropped the leading "zero dot".
That said, there do appear to be some fairly significant changes since v0.14.4.
Most importantly, this SDK patches src/HTTPSocket.h and src/Socket.h that no longer exists in the newer uWebSockets code.
https://github.com/firebase/firebase-cpp-sdk/blob/b4f9e0b45d9cf69688cdb0285627aedfcc906dd9/scripts/git/patches/uWebSockets/0001-fix-want-write-and-sprintf-deprecation.patch
It looks like src/HTTPSocket.h was refactored out on 20190902, and src/Socket.h on 20190910.
I am sure that it would be non-trivial to update to the latest uWebSockets, but it may be worth updating to at least a version closer to the refactor, but preferably to the latest.
Most of the other cmake/external dependencies seem more reasonably up to date, but it would be nice to update them to as recent as possible.
- 主要语言
- C++
- 星标
- 326
- 派生
- 138
- 平均合并
- 1 天 12 小时
- 30 天内合并 PR
- 5
环境准备
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
firebase/firebase-cpp-sdk 的其他 Issue
-
new type: question
难度 2/5 1-3 小时 新手友好度 85/100
firebase/firebase-cpp-sdk#1926 ·
-
难度 2/5 1-3 小时 新手友好度 72/100
firebase/firebase-cpp-sdk#1905 · 2 条评论 ·
-
api: firestore
难度 5/5 一周以上 新手友好度 35/100
firebase/firebase-cpp-sdk#1920 · 3 条评论 ·
-
难度 3/5 1-2 天 新手友好度 70/100
firebase/firebase-cpp-sdk#1904 · 1 条评论 ·
-
new type: question
难度 4/5 3-5 天 新手友好度 45/100
firebase/firebase-cpp-sdk#1892 · 1 条评论 ·
查看 firebase/firebase-cpp-sdk 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 92/100
espressif/esp-matter#1867 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 92/100
isce-framework/isce3#387 ·
-
upstream update
难度 2/5 1-3 小时 新手友好度 68/100
conan-io/conan-center-index#31055 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复