The firebase-admin-java 9.4.0 does not work with NIO (Non-blocking I/O).
还没有人认领这个 Issue。
评估
调研方向
首先,沿着 FirebaseOptions ThreadManager 配置和 FirebaseThreadManagers.DefaultThreadManager.doInit() 跟踪 FirebaseMessaging.sendAsync。将 firebase 线程的生命周期与 interceptors 中描述的 httpclient-dispatch 和 IO selector 行为进行比较。该 issue 未指定文件、测试或可接受的解决方案,因此在定义什么算作“done”之前,先确认预期的交接和可复现的失败。
由索引模型根据 Issue 内容生成。
描述
[READ] Step 1: Are you in the right place?
- For issues or feature requests related to the code in this repository
file a Github issue.- If this is a feature request make sure the issue title starts with "FR:".
- For general technical questions, post a question on StackOverflow
with the firebase tag. - For general Firebase discussion, use the firebase-talk
google group. - For help troubleshooting your application that does not fall under one
of the above categories, reach out to the personalized
Firebase support channel.
[REQUIRED] Step 2: Describe your environment
- Operating System version: ubuntu
- Firebase SDK version: firebase-admin-java 9.4.0
- Library version: java 17
- Firebase Product: fcm
[REQUIRED] Step 3: Describe the problem
Hello,
I am testing the firebase-admin-java SDK 9.4.0 with the following configuration:
FirebaseOptions options = FirebaseOptions.builder()
.setCredentials(googleCredentials(firebaseCredential, httpTransport))
.setDatabaseUrl(firebaseDatabaseUrl)
.setHttpTransport(httpTransport)
.setConnectTimeout(FIREBASE_CONNECT_TIMEOUT)
.setReadTimeout(FIREBASE_READ_TIMEOUT)
.setThreadManager(new CustomFirebaseThreadManager(
firebaseTaskExecutor.getThreadPoolExecutor()))
.build();
The reason I explicitly added ThreadManager is to monitor the ThreadPoolExecutor. Without this configuration, the ThreadPoolExecutor generated by FirebaseThreadManagers.DefaultThreadManager.doInit() will be used, which has a queue size of Integer.MAX_VALUE. If FCM responses are delayed, the queue can pile up, potentially causing an OOM (OutOfMemoryError).
Below is the configuration for H2AsyncClientBuilder:
H2AsyncClientBuilder h2AsyncClientBuilder = H2AsyncClientBuilder.create()
.setDefaultConnectionConfig(connectionConfig)
.evictIdleConnections(TimeValue.of(Duration.ofMinutes(10)))
.setDefaultRequestConfig(requestConfig())
.setIOReactorConfig(IOReactorConfig.custom()
.setSoTimeout(FIREBASE_READ_TIMEOUT, TimeUnit.MILLISECONDS)
.build())
.addRequestInterceptorFirst(
(HttpRequest request, EntityDetails entity, HttpContext context) -> {
activeStream.incrementAndGet();
if (context != null) {
context.setAttribute("startTime", System.nanoTime());
}
})
.addResponseInterceptorFirst(
(HttpResponse response, EntityDetails entity, HttpContext context) -> {
if (context == null || context.getAttribute("startTime") == null) {
return;
}
long startTime = Long.parseLong(context.getAttribute("startTime").toString());
long endTime = System.nanoTime();
if (startTime < endTime) {
Timer.builder(FCM_RESPONSE_TIMER_NAME)
.publishPercentiles(0.50, 0.95, 0.99)
.tags(
Lists.newArrayList(
Tag.of("host", ((HttpRoute) context.getAttribute("http.route")).getTargetHost().getHostName()),
Tag.of("http_version", context.getProtocolVersion().toString())
)
)
.register(meterRegistry)
.record(endTime - startTime, TimeUnit.NANOSECONDS);
}
activeStream.decrementAndGet();
})
.disableCookieManagement()
.setH2Config(H2Config.custom().setMaxConcurrentStreams(500 * 10).build())
.disableRedirectHandling()
.disableAutomaticRetries();
Here is the code for sending FCM messages. The postProcessExecutor is simply responsible for logging the send results:
ApiFuture<String> responseApiFuture = firebaseMessaging.sendAsync(fcmMessage);
responseApiFuture.addListener(() -> {
try {
responseApiFuture.get();
message.setResponseCode(FcmResult.SUCCESS.getCode());
postProcessor.postProcess(MessageStatus.SENT, message);
} catch (Exception e) {
log ~~~
}
}, postProcessorExecutor);
When testing this, if I set a breakpoint inside addRequestInterceptorFirst (or addResponseInterceptorFirst) in the second code block, the thread executing addRequestInterceptorFirst is the httpclient-dispatch thread.
At this point, firebaseThreadPoolTask.getActiveCount() (as set in FirebaseOptions.builder().setThreadManager()) is 1.
In other words, it seems like the firebaseThread is staying active while the httpclient-dispatch thread is running.
I would like the behavior to work as follows:
The firebaseThread performs tasks (such as SDK validation) before the HTTP call.
After handing over to httpclient-dispatch, the firebaseThread is released.
The httpclient-dispatch makes the request to the FCM server, and the IO selector detects when a response is received.
Once the IO selector detects the response, it hands over to httpclient-dispatch, which processes operations like interceptors and then passes it to postProcessorExecutor.
This behavior should prevent the firebaseThread from getting blocked when the FCM server is down or latency is high.
If the firebaseThread gets blocked, it means that the queue in the thread pool fills up, which can lead to OOM or RejectedExecutionException.
If I have misunderstood anything, please let me know.
If my understanding is correct, how can I resolve this issue?
- 主要语言
- Java
- 星标
- 620
- 派生
- 305
- 平均合并
- 4 天 9 小时
- 30 天内合并 PR
- 4
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
firebase/firebase-admin-java 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 48/100
firebase/firebase-admin-java#1231 ·
-
api: core
firebase/firebase-admin-java#1198 · 3 条评论 · 已指派 1 人 ·
-
api: remoteconfig
firebase/firebase-admin-java#1196 · 1 条评论 · 已指派 2 人 ·
-
难度 3/5 1-2 天 新手友好度 45/100
firebase/firebase-admin-java#1192 · 3 条评论 ·
-
needs-triage type: feature request
难度 3/5 1-2 天 新手友好度 45/100
firebase/firebase-admin-java#1149 · 1 条评论 ·
查看 firebase/firebase-admin-java 的全部 Issue
相似的 Issue
-
certification
难度 1/5 1 小时以内 新手友好度 80/100
-
难度 2/5 1-3 小时 新手友好度 75/100
-
[BUG] ECR GetAuthorizationToken returns a proxyEndpoint for the default region, not the request's 未关闭bug ecr
难度 2/5 1-3 小时 新手友好度 75/100
-
Needs: Triage Type: Feature request
难度 2/5 1-3 小时 新手友好度 70/100
AntennaPod/AntennaPod#8794 ·
-
agentic-workflows
难度 2/5 1-3 小时 新手友好度 65/100
github/copilot-sdk#2760 ·