AndroidNotification::VibrateTimingsMillis not operating as documented

未关闭
#322 3 条评论 0 个 reaction 已指派 2 人 在 GitHub 查看

维护者通常 1 天内回复

@chong-shao 已经在做这个了。

开始于 2022年3月30日。

评估

这个 Issue 还没有评估数据。

描述

api: messaging
[REQUIRED] Step 2: Describe your environment
  • Operating System version: Windows 10 Enterprise
  • Firebase SDK version: 2.3.0
  • Firebase Product: Firebase Cloud Messaging
  • .NET version: 6.0
  • OS: Windows 0 Enterprise
[REQUIRED] Step 3: Describe the problem

The AndroidNotification::VibrateTimingMillis property is documented as follows:

Gets or sets a list of vibration timings in milliseconds in the array to use. The first value in the
array indicates the duration to wait before turning the vibrator on. The next value
indicates the duration to keep the vibrator on. Subsequent values alternate between
duration to turn the vibrator off and to turn the vibrator on.

Today I wanted to send a notification that would vibrate for 500 milliseconds, so I set this property as follows:

AndroidNotification notification = new
{
    DefaultVibrateTimings = false,
    VibrateTimingsMillis = new long[] { 0, 500 }
};

On the device though, this resulted in a very long vibration, that lasted for several seconds.

After experimenting, sending a value of { 0, 1 } results in a vibration lasting 1 second - I've reviewed the relevant code for this (in VibrateTimingsString) and tested it on its own, and the above code results in the value 0s, 0.500000000s being sent to the API, which appears correct.

I'm not sure if this is a fault on the device I was testing against as it is running a very dated version of Android unfortunately (we're stuck with it due to customer requirements and it's stuck on Android 7.1.1).

PS: I also noticed a few possible micro-optimisations that could be made to some of this new code, such as pre-sizing the list for the timingsStringList, I'm not sure if it's worth opening a PR for these changes.

主要语言
C#
星标
407
派生
147
平均合并
2 天 10 小时
30 天内合并 PR
12

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

firebase/firebase-admin-dotnet 的其他 Issue

查看 firebase/firebase-admin-dotnet 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。