Icon instance type not being respected
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- react, typescript
调研方向
Start by tracing how figma.instance<React.FunctionComponent> is rendered in the Code Connect preview, then compare it with the handling of icon instances passed as props. The issue does not name source files or tests, so locate the relevant preview and instance handling first. Done means the nested icon is shown as {ArrowRightMedium} instead of <ArrowRightMedium />.
由索引模型根据 Issue 内容生成。
描述
Hello,
I've setup my icon's example code to be react components. In the majority of my connections when icon's are being used in a prop it shows correctly as a react component but when its a child of a component it shows as a JSX element. I need it to always show as a react component not jsx.
Icon:
figma.connect(
'https://www.figma.com/design/OMITTED/%E2%9D%96-00-Assets?node-id=OMITTED',
{
variant: {
size: 'medium-24px',
direction: '← left',
},
example: () => ArrowLeftMedium,
}
);
Component connection:
figma.connect(
IconButton,
'https://www.figma.com/design/OMITTED/%E2%9D%96-02-Elements?node-id=OMITTED,
{
props: {
...other code,
children: figma.nestedProps('icon-label-icon', {
IconPrefix: figma.boolean('show-icon-L', {
true: figma.instance<React.FunctionComponent>('icon-left'),
false: undefined,
}),
IconSuffix: figma.boolean('show-icon-R', {
true: figma.instance<React.FunctionComponent>('icon-right'),
false: undefined,
}),
}),
},
example: ({ children, ...props }) => (
<IconButton {...props}>
{children.IconPrefix}
{children.IconSuffix}
</IconButton>
),
}
);
In the code connect preview window:
What I would like to be shown based on this example is the icon as {ArrowRightMedium} not <ArrowRightMedium />
Could I be directed on how to correct this? Thank you
- 主要语言
- TypeScript
- 星标
- 1.6k
- 派生
- 126
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
figma/code-connect 的其他 Issue
-
normalizePropName strips `#` characters from Figma property names instead of only the `#id` suffix未关闭
难度 2/5 1-3 小时 新手友好度 72/100
figma/code-connect#419 ·
-
feature request
难度 2/5 1-3 小时 新手友好度 66/100
figma/code-connect#403 ·
-
feature request
难度 5/5 一周以上 新手友好度 38/100
figma/code-connect#414 ·
-
feature request
难度 4/5 3-5 天 新手友好度 48/100
figma/code-connect#413 · 1 条评论 ·
-
feature request
难度 4/5 3-5 天 新手友好度 54/100
figma/code-connect#412 · 1 条评论 ·
查看 figma/code-connect 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 78/100
vercel-labs/ui#540 ·
维护者通常 1 天内回复
-
accepted ai-dev ai-implementing
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
-
Negative values skip k/M abbreviation and medium decimal format on line, stacked-area, and tooltip未关闭
难度 2/5 1-3 小时 新手友好度 84/100
britecharts/britecharts#1255 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 70/100
jeanibarz/knowledge-base-mcp-server#1268 ·
维护者通常 1 天内回复