`text/plain` request bodies are parsed instead of streamed: non-UTF-8 bytes corrupted, bodies over 1 MiB rejected with 413
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 82/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- javascript, node.js
- 领域
- backend, networking
调研方向
从 index.js 第718–719行附近开始,那里是代理注册请求体解析器的位置,然后阅读附近的解析器测试。添加覆盖测试,检查包含非 UTF-8 字节的 text/plain 上传,以及超过默认请求体限制的请求体。接着注册所需的解析器,并确认测试显示请求体逐字节转发,且不会返回 413 响应。
由索引模型根据 Issue 内容生成。
描述
Prerequisites
- I have written a descriptive issue title
- I have searched existing issues to ensure the bug has not already been reported
Fastify version
5.12.8
Plugin version
@fastify/http-proxy 11.6.6 (also main at ce4d419), @fastify/reply-from 12.8.1
Node.js version
26.13.0
Operating system
Linux
Operating system version (i.e. 20.04, 11.3, 10)
Debian 12
Description
The README says non-JSON payloads are streamed directly to the destination. That holds for text/csv or application/octet-stream, but not for text/plain: Fastify's built-in text/plain parser still runs, because the plugin only overrides application/json and * (index.js lines 718-719). The body is decoded as UTF-8 and re-sent as a string, so a text/plain upload in any other charset is corrupted, and a text/plain upload larger than bodyLimit gets a 413 instead of being streamed.
// repro.mjs
import http from 'node:http';
import Fastify from 'fastify';
import proxy from '@fastify/http-proxy';
// upstream: report how many bytes arrived and the first bytes
http.createServer((req, res) => {
const chunks = [];
req.on('data', (c) => chunks.push(c));
req.on('end', () => {
const b = Buffer.concat(chunks);
res.end(`got ${b.length} bytes: ${b.subarray(0, 6).toString('hex')}`);
});
}).listen(3001);
const app = Fastify();
app.register(proxy, { upstream: 'http://127.0.0.1:3001' });
await app.listen({ port: 3000 });
const send = async (type, body) => {
const r = await fetch('http://127.0.0.1:3000/upload', { method: 'POST', headers: { 'content-type': type }, body });
console.log(type.padEnd(30), `sent ${body.length} bytes: ${body.subarray(0, 6).toString('hex')} ->`, r.status, await r.text());
};
const latin1 = Buffer.from('café crème', 'latin1');
await send('text/plain; charset=iso-8859-1', latin1);
await send('text/csv; charset=iso-8859-1', latin1);
await send('text/plain', Buffer.alloc(2 * 1024 * 1024, 'a'));
await send('application/octet-stream', Buffer.alloc(2 * 1024 * 1024, 'a'));
process.exit(0);
node repro.mjs prints:
text/plain; charset=iso-8859-1 sent 10 bytes: 636166e92063 -> 200 got 14 bytes: 636166efbfbd
text/csv; charset=iso-8859-1 sent 10 bytes: 636166e92063 -> 200 got 10 bytes: 636166e92063
text/plain sent 2097152 bytes: 616161616161 -> 413 {"statusCode":413,"code":"FST_ERR_CTP_BODY_TOO_LARGE","error":"Payload Too Large","message":"Request body is too large"}
application/octet-stream sent 2097152 bytes: 616161616161 -> 200 got 2097152 bytes: 616161616161
Link to code that reproduces the bug
https://gist.github.com/trackoor/a9dc305ecd07ded3018ca5fea688a582
Expected Behavior
text/plain bodies reach the upstream byte for byte, like every other non-JSON type: 10 bytes 636166e92063 in the first line and 200 got 2097152 bytes in the third. Registering bodyParser for text/plain next to application/json should be enough.
Found with a differential-testing tool; the report was drafted with AI assistance and reviewed and edited by me.
Credit: https://ucsbplse.github.io/
- 主要语言
- JavaScript
- 星标
- 394
- 派生
- 105
- 平均合并
- 9 小时 34 分钟
- 30 天内合并 PR
- 2
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
fastify/fastify-http-proxy 的其他 Issue
-
reply.fromParameters() drops query params after a second "?"可能已有人在做 @RaphaelFakhri 于 2 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
fastify/fastify-http-proxy#491 ·
查看 fastify/fastify-http-proxy 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
arfct/timezone.fyi#19 ·
-
难度 2/5 1-3 小时 新手友好度 82/100
tensorflow/tfjs#8754 ·
-
bug main ui
难度 2/5 1-3 小时 新手友好度 78/100
openhab/openhab-webui#4671 ·
维护者通常 1 天内回复
-
scratch-paint's npm test does not run lint, so CI never lints paint; one lint error is currently in develop可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 86/100
scratchfoundation/scratch-editor#754 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 96/100
google/site-kit-wp#14102 ·
维护者通常 2 天内回复