Cyclic imports between app/desktop/server/core flagged by pylint (R0401)

未关闭
#42 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
55/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
cli

调研方向

Run pylint src/profiles to list the cyclic-import warnings. Read AGENTS.md for the boundary rule, then inspect app.py and profiles/__init__.py as hubs. Extract server bootstrap from app.py and keep core/config/models.py free of imports. Done means pylint src/profiles reports zero R0401 without new lazy-import workarounds.

由索引模型根据 Issue 内容生成。

描述

code-quality tech-debt

pylint src/profiles reports 16 cyclic-import warnings rooted in profiles.app reaching into every layer while those layers (or their shared models) are also imported transitively from it. Representative chain:

profiles -> profiles.app -> profiles.desktop.lifecycle -> profiles.server.app
         -> profiles.server.routes.scan -> profiles.core.processing.scanner
         -> profiles.core.config.service -> profiles.core.config.matcher
         -> profiles.core.config.models

It works today because the cycles close on import-order luck (module-level imports at the bottom of app.py, lazy imports elsewhere), but it violates the AGENTS.md boundary rule ("Aucune dépendance circulaire entre modules") and makes refactoring fragile.

Likely levers:

  • app.py is the hub: extract the server bootstrap wiring (routes needing server_state, static mount, port discovery) into a dedicated bootstrap module so app.py only calls it, instead of importing route modules transitively.
  • core.config.models is imported by everything including app — keep it dependency-free (the cycle enters through service/matcher chains).
  • Consider making profiles/__init__ (which resolves __version__) not import subpackages.

Acceptance: pylint src/profiles reports zero R0401 without new import-outside-toplevel workarounds beyond the documented lazy imports.

主要语言
Python
星标
1
派生
1
平均合并
4 小时 46 分钟
30 天内合并 PR
55

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

falbany/ProFiles 的其他 Issue

查看 falbany/ProFiles 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。