Should the value of `error` be mutable?
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 功能
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 领域
- testing
调研方向
查看 perfect-numbers 的 canonical-data.json 示例和 problem-specifications PR 1691,然后检查不可变性 CI 检查以及讨论中提到的任何 tests.toml 断言。确定仅修改错误措辞是否能保留测试含义;完成的标准是已记录该策略,并且相关的 validation 或断言已一致更新。
由索引模型根据 Issue 内容生成。
描述
Example
In perfect-numbers we have this test case:
https://github.com/exercism/problem-specifications/blob/8df6cb2ed8e77aa3ac0c02744cd9ddb83920f5f2/exercises/perfect-numbers/canonical-data.json#L121-L130
And we notice (see https://github.com/exercism/problem-specifications/pull/1691) that we would like to make this change:
{
"uuid": "72445cee-660c-4d75-8506-6c40089dc302",
- "description": "Zero is rejected (not a natural number)",
+ "description": "Zero is rejected (not a positive integer)",
"property": "classify",
"input": {
"number": 0
},
"expected": {
- "error": "Classification is only possible for natural numbers."
+ "error": "Classification is only possible for positive integers."
}
We seem to have decided that description is allowed to mutate when the "meaning is unchanged" (that is, we do not add a reimplements test case for e.g. a simple description-only typo fix).
The question is: should the contents of an error also be considered mutable when the "meaning is unchanged", or should that require a new test case?
Discussion
My initial opinion is something like:
- We said that
descriptionshould be mutable if we don't change the "meaning" of the test. - There are some useful error-message changes that don't change the "meaning" of the test either, and the value of
erroris similar to the "description" of the error. In the limiting case, it seems messy to add a new test case just to fix a typo in anerrorvalue. - Therefore, directly mutating the
errorvalue should similarly be allowed when the "meaning is unchanged".
Drawbacks:
- Is there a track that asserts something about the contents of the error message for this kind of test? Such a track would have to update that assertion, even though their
tests.tomldidn't change. - The CI check for immutability would need to check that
expecteddoesn't change, but make a special case for anerror-only change.
- 主要语言
- Ruby
- 星标
- 362
- 派生
- 566
- 平均合并
- 15 小时 13 分钟
- 30 天内合并 PR
- 8
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
exercism/problem-specifications 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 90/100
exercism/problem-specifications#2686 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 25/100
exercism/problem-specifications#2704 · 21 条评论 · 8 个 reaction ·
维护者通常 1 天内回复
-
难度 1/5 1-3 小时 新手友好度 35/100
exercism/problem-specifications#2153 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 35/100
exercism/problem-specifications#2120 · 7 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 25/100
exercism/problem-specifications#2108 · 1 条评论 · 5 个 reaction ·
维护者通常 1 天内回复
查看 exercism/problem-specifications 的全部 Issue
相似的 Issue
-
Bug Ruby Waiting for: Product Owner
难度 2/5 1-3 小时 新手友好度 78/100
getsentry/sentry-ruby#3228 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
開発用DockerイメージにPlaywrightのシステム依存を追加する可能已有人在做 @momocus 今天认领。 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
sakazuki-org/sakazuki#1453 ·
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 76/100
jenkins-infra/jenkins.io#9615 · 1 条评论 ·
维护者通常 1 天内回复