Instructions for Zipper exercise are misleading.
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 45/100
- Issue 类型
- 文档
- 描述清晰度
- 基本清楚
- 活跃度
- 冷清
- 技术栈
- javascript
调研方向
先从 JavaScript track 的 Zipper exercise instructions 和 test suite 入手,然后将其中对 Zipper 的描述与链接的 Wikipedia 和 Wikibooks 参考资料进行比较。判断该 exercise 是否应澄清函数式模型、为不可变树和 Zipper 状态添加测试,或进行重命名,并更新相关文档或测试,使预期行为明确无歧义。
由索引模型根据 Issue 内容生成。
描述
Hi,
Issue:
I don't know if this is the right place to report this but I found the instructions for Zipper on the Javascript track to be misleading.
The instructions say "Zippers are a purely functional way of navigating within a data structure and manipulating it. They essentially contain a data structure and a pointer into that data structure (called the focus)."
In a purely functional setting, the data structure is immutable. The pointer into the data structure could read from inside the structure, but it couldn't modify it in any way. The only way to set a new value is to build new structure with the modified value based on the old data.
The linked Wikipedia page says of list-zippers: "Consequently, a list-zipper is a pair consisting of both the location as a context or starting point, and a recording or path that permits reconstruction from that starting location." And the reference that Wikipedia uses says (in a mythological setting about exploring a labyrinth): "The zipper is a pair of Ariadne's thread and the current sub-labyrinth that the player stands on top."
The point being the Zipper does not contain the full data structure and a pointer. It is two things:
- The steps (thread) leading up to the focused node (Did I go left or right here? What was the value of the node here? What was the other subtree?)
- The rest of the structure, from the focused node down (In this case the subtree starting at the focused node).
From these two things, you can rebuild the full structure, including making modifications by creating new subtrees with modified values as you reverse the steps.
Now, I managed to implement a Zipper according to the description on Wikipedia but I am not sure it makes sense to do this in Javascript. As the Wikipedia says, "In a non-purely-functional programming language, it may be more convenient to simply traverse the original data structure and modify it directly (perhaps after deep cloning it, to avoid affecting other code that might hold a reference to it)." But doing this is not a Zipper.
Potential Solutions:
-
Update problem statement to better reflect what a Zipper is. (Recorded thread + rest of structure)
-
Modify the test suite: If we still want a Zipper in Javascript, then the test suite needs to be more detailed. First, the input tree should be frozen/immutable. It should check that all output is also immutable and all intermediate stages do not have side effects (i.e a new Zipper with a new thread and a new tree is created at every stage).
-
Add guiding tests: Have tests that check what the current thread is in the Zipper after running different methods and what the current subtree is. E.g. if zipper is
Zipper.fromTree(bt(1, bt(2, null, leaf(3)), leaf(4))), the Zipper returned by zipper.left() will have subtreebt(2, null, leaf(3))and thread will be something like[{direction: "left", value: 1, otherSubtree: leaf(4)}]This will make the exercise much easier, since the nature of what a Zipper is will be clear. You may not want to do this though since the problem is specified as Hard; a suitable description on the problem page may be sufficient. -
Change the problem to making a copy of the tree and maintaining a pointer into the tree. The problem would need a different name and couldn't refer to the Zipper data structure.
Anyway, I haven't contributed here before so I don't know what the procedure is for this sort of thing. Also I'm not particularly familiar with Javascript so there might be better solutions than my suggestions above. Please let me know your thoughts and if I should do anything.
Thanks,
Josh
- 主要语言
- JavaScript
- 星标
- 652
- 派生
- 658
- 平均合并
- 13 小时 46 分钟
- 30 天内合并 PR
- 6
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
exercism/javascript 的其他 Issue
-
难度 4/5 3-5 天 新手友好度 35/100
exercism/javascript#2865 ·
-
难度 3/5 1-2 天 新手友好度 45/100
exercism/javascript#2847 ·
-
难度 3/5 1-2 天 新手友好度 42/100
exercism/javascript#2832 ·
-
exercism/javascript#2310 · 22 条评论 · 已指派 1 人 ·
-
pinned :pushpin:
难度 5/5 一周以上 新手友好度 5/100
exercism/javascript#2144 ·
查看 exercism/javascript 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
-
难度 2/5 1-3 小时 新手友好度 75/100
mksglu/context-mode#1200 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
neondatabase/website#5944 ·
-
module: core
难度 2/5 1-3 小时 新手友好度 75/100
bigbluebutton/bigbluebutton#25849 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
jaegertracing/jaeger-ui#4506 ·