Firefox E2E: print checks that need WebGL or Chromium do not run on CI
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 活跃
- 技术栈
- github-actions, javascript, playwright, three.js
- 领域
- testing-qa
调研方向
Start with the five rows in the issue table: print-idevices.spec.ts, idevices/three-d-viewer.spec.ts and idevices/three-sixty-viewer.spec.ts, each gated by test.skip(!(await hasWebGL(page))), plus the two PDF checks that return early. Read the CI Firefox job config and the hasWebGL helper before changing anything. Done means the five checks run green in the Firefox job, or each remaining skip links back to this issue with a reason.
由索引模型根据 Issue 内容生成。
描述
On the CI Firefox job, five print checks are skipped or end early. They run in full in the Chromium
job, so nothing goes untested, but the Firefox coverage is lost. Raised by @erseco in the review of
#2539.
| Spec | Test | What does not run | Why |
|---|---|---|---|
print-idevices.spec.ts |
waits for real molecule surfaces and reuses the viewer across print previews | the whole test | Firefox has no WebGL on the GPU-less runners |
idevices/three-d-viewer.spec.ts |
keeps the GLB / GLTF / STL model in the copy the desktop app prints | the whole test | no WebGL (GLB needs WebGL 2) |
idevices/three-sixty-viewer.spec.ts |
draws the viewer in the editor, with three.js loaded before it starts | the whole test | no WebGL |
print-idevices.spec.ts |
keeps all nine categories with their cards on printed sheets | the PDF checks | the Firefox job installs no Chromium, which makes the PDF |
print-idevices.spec.ts |
keeps the colour of a Material block icon when printing, and of nothing around it | the PDF checks | same |
The first three call test.skip(!(await hasWebGL(page)), …). The last two add a note to the
report and return before checking the PDF.
Proposal
- Give Firefox a software WebGL on the CI runners, if it can be enabled reliably, and drop the
three skips. - Install Chromium in the Firefox job as well, so the two PDF checks run there too.
Done when
- The five checks run in the Firefox job, or each remaining skip says why Firefox cannot run it.
- The skips and early returns link to this issue until then.
- 主要语言
- JavaScript
- 星标
- 145
- 派生
- 33
- 平均合并
- 3 天 16 小时
- 30 天内合并 PR
- 89
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
exelearning/exelearning 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 77/100
exelearning/exelearning#2677 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
exelearning/exelearning#2497 ·
维护者通常 1 天内回复
-
Mermaid: long node labels are cut off in Chrome and Edge at some zoom levels, and the cut is saved in previews and exports可能已有人在做 @erseco 于 12 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 76/100
exelearning/exelearning#2490 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
exelearning/exelearning#2455 · 1 条评论 ·
维护者通常 1 天内回复
-
non-english
难度 2/5 1-3 小时 新手友好度 64/100
exelearning/exelearning#2448 · 1 条评论 ·
维护者通常 1 天内回复
查看 exelearning/exelearning 的全部 Issue
相似的 Issue
-
enhancement good first issue hacktoberfest help wanted
难度 2/5 1-3 小时 新手友好度 85/100
BinaryBaconLabs/todo-app#18 ·
-
bug
难度 2/5 1-3 小时 新手友好度 88/100
维护者通常 1 天内回复
-
44-x-y bug :beetle:
难度 1/5 1 小时以内 新手友好度 82/100
electron/electron#55528 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 85/100
react/react-native#59699 ·
维护者通常 2 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100