Elasticsearch connection string `scope` key has no effect on index names
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with src/Exceptionless.Core/Configuration/ElasticsearchOptions.cs, especially ReadFromConfiguration and ParseConnectionString, then check src/Exceptionless.Core/Jobs/Elastic/DataMigrationJob.cs and the index configuration files named in the issue. Trace how Scope, ScopePrefix, and EnableSnapshotJobs are set for both Elasticsearch configurations. Done when the scope behavior matches the chosen expected outcome and index prefixes use consistent separators.
由索引模型根据 Issue 内容生成。
描述
ElasticsearchOptions parses a scope key from ConnectionStrings:Elasticsearch, but index names are built from ScopePrefix, which is computed from AppScope before the connection string is parsed. Setting scope= in the Elasticsearch connection string changes nothing.
Where
ElasticsearchOptions.ReadFromConfigurationsetsScope = appOptions.AppScopeandScopePrefixfrom it, then callsParseConnectionString.ParseConnectionStringoverwritesScopefrom thescopekey but never recomputesScopePrefix.- Every index uses
ScopePrefix, e.g.EventIndexand the migrations index. Nothing readsElasticsearchOptions.Scopefor the main cluster. - The only reader of
ScopeisDataMigrationJob, forElasticsearchToMigrate, where it is used as a raw prefix with no-separator (scope=prodgivesprodorganizations-v1, while the main cluster's prefix would beprod-).
Steps to reproduce
- Run with
EX_ConnectionStrings__Elasticsearch=server=http://localhost:9200;scope=testand noEX_AppScope. - List indexes: they are
events-v1-*,stacks-v1,organizations-v1, etc., without atest-prefix.
Expected
Either scope in the Elasticsearch connection string prefixes index names the same way AppScope does, or the key is not parsed at all.
Suggested fix
Set ScopePrefix at the end of ParseConnectionString (ScopePrefix = String.IsNullOrEmpty(Scope) ? "" : $"{Scope}-"), so both the main and ElasticsearchToMigrate options get it, and compute the EnableSnapshotJobs default after parsing, since it depends on ScopePrefix. In DataMigrationJob, use ElasticsearchToMigrate.ScopePrefix so both sides use the same - separator. If per-connection scoping isn't wanted, remove the scope parsing for the main connection string and keep it only for ElasticsearchToMigrate.
- 主要语言
- C#
- 星标
- 2.5k
- 派生
- 508
- 平均合并
- 2 天 17 小时
- 30 天内合并 PR
- 40
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
exceptionless/Exceptionless 的其他 Issue
-
bug documentation
难度 2/5 1-3 小时 新手友好度 78/100
exceptionless/Exceptionless#2707 ·
维护者通常 1 天内回复
-
enhancement
难度 2/5 1-3 小时 新手友好度 85/100
exceptionless/Exceptionless#2706 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
exceptionless/Exceptionless#2705 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 88/100
exceptionless/Exceptionless#2704 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 73/100
exceptionless/Exceptionless#2703 ·
维护者通常 1 天内回复
查看 exceptionless/Exceptionless 的全部 Issue
相似的 Issue
-
possible bug
难度 2/5 1-3 小时 新手友好度 74/100
-
Include host.wslc.internal in the HTTPS development certificate可能已有人在做 @afscrome 今天认领。 未关闭area-commandlinetools
难度 2/5 1-3 小时 新手友好度 70/100
dotnet/aspnetcore#70122 · 1 条评论 ·
维护者通常 1 天内回复
-
:1st_place_medal: good first issue :cowboy_hat_face: refactor :roller_coaster: enhancement
难度 2/5 1-3 小时 新手友好度 68/100
ApplETS/Backend-Hello#78 ·
-
难度 2/5 1-3 小时 新手友好度 74/100
维护者通常 2 天内回复
-
status/triage
难度 2/5 1-3 小时 新手友好度 85/100
Altinn/altinn-studio#21642 ·
维护者通常 1 天内回复