Guidelines too opinionated about squashing commits on develop
@vpanjganj 已经在做这个了。
开始于 2021年7月13日。
评估
这个 Issue 还没有评估数据。
描述
In 1.2, we can read the following:
You can use --autosquash to squash all your commits to a single commit. Nobody wants many commits for a single feature in develop branch. read more...
I think that asserting that nobody wants that is a fallacy. There are good reasons for which you would want to keep those commits separated even in develop branch:
- know what the reason of a change was when doing a git blame, which is naturally in the commit message/description and not in the feature
- having more precision for git bisect: squashing makes you lose information as you only know which feature caused a regression, rather than a specific commit (the latter narrows the scope)
Those are the reasons why I never squash my commits into a feature commit. You should therefore mention in your guidelines that this is subjective.
- 主要语言
- JavaScript
- 星标
- 29.4k
- 派生
- 3.1k
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
elsewhencode/project-guidelines 的其他 Issue
-
难度 5/5 一周以上 新手友好度 20/100
elsewhencode/project-guidelines#176 · 1 条评论 ·
-
improvement
elsewhencode/project-guidelines#160 · 3 个 reaction · 已指派 1 人 ·
-
improvement
elsewhencode/project-guidelines#140 · 已指派 1 人 ·
-
improvement question
elsewhencode/project-guidelines#134 · 已指派 1 人 ·
-
suggestion
elsewhencode/project-guidelines#111 · 1 条评论 · 3 个 reaction · 已指派 1 人 ·
查看 elsewhencode/project-guidelines 的全部 Issue
相似的 Issue
-
Bug
难度 2/5 1-3 小时 新手友好度 70/100
Automattic/safe-publish#594 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
dream-num/dsh-univer-office#104 ·
-
comp/dashboard invalid P3
难度 2/5 1-3 小时 新手友好度 70/100
NousResearch/hermes-agent#121143 ·
-
难度 2/5 1-3 小时 新手友好度 75/100
avniproject/avni-webapp#1811 ·
-
area/auroraboot area/webui bug
难度 2/5 1-3 小时 新手友好度 75/100