Larger code restructuring to keep it more approachable
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 25/100
- Issue 类型
- 重构
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- electron, elixir, macos, sqlite, tauri
- 领域
- build-system, desktop, devtools
调研方向
首先查看链接的 feat/mybranch 分支和 ci-path-on-osx-deps.txt 文件，然后将其中的重构和 macOS 动态库更改与仓库进行比较。要视为完成，需要由维护者决定是否采用这一更大范围的重构以及报告的 macOS 修复。
由索引模型根据 Issue 内容生成。
描述
Hey @dominicletz , thanks for this project!
After fighting with Tauri (v2) and Electron, I'm willing to accept less polish in features for the beloved experience of using Elixir even for desktop apps! Having a proper REPL and all the great Elixir tooling is sooo nice!
I hit a bug today when integrating Destop.Deployment package into my app... And when I looked into the code, I found it somewhat hard to follow, to be honest. And since I want to use Elixir on the desktop for longer term, I decided to clean it up. As you can imagine, it became a larger change.
Hence I will not open a PR right now, so you do not get a heart attack (I know the feeling). My changes are here:
Please take a look and see if you like it. I will be using my fork, so there is no rush for you to do anything. It is mostly the same code, with more structure, more smaller modules, simpler conventions and a nice way to organize a sequence of actions in a conventional way.
I also fixed the issue with dynamic libraries for OSX (where the install name does not match the actual path). It works now with the default SQLITE package, no need to use your fork (at least on OSX). - https://github.com/maxohq/desktop-deployment/blob/feat/mybranch/issues/ci-path-on-osx-deps.txt
Anyways, since I hope to use this package in the future, I'm willing to contribute some polish and smaller fixes to it, that I encounter in my work.
Have a great weekend!
Roman
- 主要语言
- C
- 星标
- 7
- 派生
- 9
- 平均合并
- 2 天 12 小时
- 30 天内合并 PR
- 1
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
elixir-desktop/deployment 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 72/100
elixir-desktop/deployment#13 · 2 条评论 ·
-
难度 4/5 3-5 天 新手友好度 30/100
elixir-desktop/deployment#9 · 1 条评论 ·
-
难度 3/5 1-2 天 新手友好度 25/100
elixir-desktop/deployment#7 · 2 条评论 ·
-
难度 4/5 3-5 天 新手友好度 35/100
-
难度 4/5 3-5 天 新手友好度 45/100
elixir-desktop/deployment#4 · 8 条评论 ·
查看 elixir-desktop/deployment 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 70/100
-
难度 2/5 1-3 小时 新手友好度 70/100
-
难度 2/5 1-3 小时 新手友好度 66/100
FujiNetWIFI/fujinet-lib#186 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 70/100
PackageKit/PackageKit#1027 ·