Evict stale partition mappings for vanished/detached relations in Partitions.handle_relation/2

未关闭
#4,583 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
68/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
冷清
技术栈
elixir, postgres
领域
backend, databases

调研方向

从 packages/sync-service/lib/electric/shapes/partitions.ex 开始,阅读 handle_relation/2 和 expand_change/2,并检查 clean_up_partitions/1 的语义。在添加涵盖 drop 或 detach、以普通表的形式使用相同名称重新创建,以及变更扩展的回归测试之前,先检查现有的 partition 和 ShapeLogCollector 测试。完成的标准是:移除过时的映射,同时不使 partition 所有权或活动计数失去同步,并且重新创建的表的变更不会发送到旧的 root shape。

由索引模型根据 Issue 内容生成。

描述

Summary

Electric.Shapes.Partitions.handle_relation/2 does not evict stale entries from the partitions map when a relation stops being a tracked partition. Because handle_txn_fragment/2 expands changes by {schema, table} name, a stale mapping can silently mis-route changes to the wrong root shape after a drop/detach + same-name recreation.

Surfaced by a Codex review on #4565 (commit a4dcc7d61), but the behavior is pre-existing — that PR only made the :table_not_found path reachable without crashing.

The bug

The partition map maps partition_table → [root_table], and expansion looks it up by name:

defp expand_change(%{relation: relation} = change, state) do
  [change | state.partitions |> Map.get(relation, []) |> Enum.map(&%{change | relation: &1})]
end

Two branches of handle_relation/2 return the state unchanged without clearing a previously-tracked entry for that name:

# packages/sync-service/lib/electric/shapes/partitions.ex
{:ok, _} ->
  {:ok, state}            # relation no longer has a parent (detached / never partitioned)

:table_not_found ->
  # the table was dropped (or dropped and recreated under a new oid) ...
  {:ok, state}            # added in #4565

If a tracked partition P of root R is dropped (or detached) and a new table with the same {schema, table} name is later created as a non-partition, the stale partitions[P] = [R] entry persists. Changes to the new P then get duplicated onto the old root shape R, which is incorrect.

Why it's narrow

It requires all of:

  • an active shape on the partitioned root R,
  • partition P dropped/detached,
  • a new relation recreated with the exact same schema-qualified name,
  • recreated as a plain/non-partition table (if recreated as a partition, the {:ok, %{parent: ...}} branch overwrites the stale entry, so no bug),
  • changes flowing to the recreated table.

Fix considerations

  • Evict the vanished/detached relation from partitions in both the :table_not_found and the no-parent {:ok, _} branches — fixing only one (as the inline suggestion did) leaves the identical hole in the other.

  • Eviction must be ownership-aware. Entries in partitions come from two places with different bookkeeping:

    • add_shape/3 — also tracked in partition_ownership and counted in active,
    • handle_relation/2 discovery — not tracked in partition_ownership.

    A blind Map.delete/2 on a relation message could desync partitions from partition_ownership / active for shape-owned children, so the cleanup needs to account for ownership (likely reuse / extend clean_up_partitions/1 semantics rather than delete directly).

  • Add a regression test that reproduces drop/detach → recreate-as-plain-table → asserts the change is not duplicated to the old root shape.

References

  • PR #4565 — "Don't crash ShapeLogCollector on introspection failures in the replication path"
  • File: packages/sync-service/lib/electric/shapes/partitions.ex (handle_relation/2, expand_change/2)
主要语言
TypeScript
星标
10.4k
派生
399
PR 合并指标
30 天内没有已合并 PR

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

electric-sql/electric 的其他 Issue

查看 electric-sql/electric 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。