Large-body slots are shared by everyone behind one OAuth client

未关闭
#435 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
48/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
javascript

调研方向

Read the large-body slot handling around createLargeBodies and how caller.client and identityKey are defined. Then review rest.md and security.md, which describe the current per-token or per-OAuth-client behavior. Decide whether slots should use the person when a subject is present and fall back to the client otherwise; done means the behavior and both documents agree.

由索引模型根据 Issue 内容生成。

描述

area:server

The slots for large request bodies (createLargeBodies, 2 in total and 1 per caller) are keyed by caller.client. That key is a static token's name, or an OAuth client id. As a result, every person who signs in through the same OAuth client shares one slot. One person sending a large inline report makes everyone else on that client wait or get BUSY.

Nothing is broken today: the limit still protects the server. It is only coarser than "per person".

Question: should the key be the person (identityKey) when a subject is present, falling back to the client? Decide this, then update rest.md and security.md, which describe the slot as per token or OAuth client.

主要语言
JavaScript
星标
1
派生
1
平均合并
3 小时 34 分钟
30 天内合并 PR
213

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

eizedev/pivotkit 的其他 Issue

查看 eizedev/pivotkit 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。