example from documentation does not compile

未关闭
#439 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

  • #444 来自 @veeceey —— 已关闭,未合并
  • #456 来自 @TrueFurina —— 已关闭,未合并

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
45/100
Issue 类型
文档
描述清晰度
基本清楚
活跃度
停滞
技术栈
rust
领域
documentation

调研方向

首先定位包含 PublicError、ErrorRepr、Foo 和 throw_foo 定义的文档示例,然后按所示方式编译该示例。确认该示例不再产生 E0277 或 E0308,并且其文档所述的错误处理行为仍保持不变。

由索引模型根据 Issue 内容生成。

描述

// Private and free to change across minor version of the crate.
#[derive(thiserror::Error, Debug)] // PublicError is public, but opaque and easy to keep compatible.
#[error(transparent)]
pub struct PublicError(#[from] ErrorRepr);

impl PublicError {
    // Accessors for anything we do want to expose publicly.
}

// Private and free to change across minor version of the crate.
#[derive(thiserror::Error, Debug)]
enum ErrorRepr {
    #[error("foo")]
    Foo(#[from] Foo),
}

#[derive(thiserror::Error, Debug)]
#[error("foo_text")]
struct Foo;

fn throw_foo() -> Result<(), Foo> {
    return Err(Foo);
}

fn main() -> Result<(), PublicError> {
    throw_foo()?;
    println!("Hello, world!");
}
error[E0277]: `?` couldn't convert the error to `PublicError`
  --> src/main.rs:26:16
   |
25 | fn main() -> Result<(), PublicError> {
   |              ----------------------- expected `PublicError` because of this
26 |     throw_foo()?;
   |     -----------^ the trait `From<Foo>` is not implemented for `PublicError`
   |     |
   |     this can't be annotated with `?` because it has type `Result<_, Foo>`
   |
note: `PublicError` needs to implement `From<Foo>`
  --> src/main.rs:4:1
   |
 4 | pub struct PublicError(#[from] ErrorRepr);
   | ^^^^^^^^^^^^^^^^^^^^^^
note: alternatively, `Foo` needs to implement `Into<PublicError>`
  --> src/main.rs:19:1
   |
19 | struct Foo;
   | ^^^^^^^^^^
   = note: the question mark operation (`?`) implicitly performs a conversion on the error value using the `From` trait
   = help: the trait `From<Foo>` is not implemented for `PublicError`
           but trait `From<ErrorRepr>` is implemented for it
   = help: for that trait implementation, expected `ErrorRepr`, found `Foo`

error[E0308]: mismatched types
  --> src/main.rs:25:14
   |
25 | fn main() -> Result<(), PublicError> {
   |    ----      ^^^^^^^^^^^^^^^^^^^^^^^ expected `Result<(), PublicError>`, found `()`
   |    |
   |    implicitly returns `()` as its body has no tail or `return` expression
   |
   = note:   expected enum `Result<(), PublicError>`
           found unit type `()`

Some errors have detailed explanations: E0277, E0308.
For more information about an error, try `rustc --explain E0277`.
error: could not compile `tetete` (bin "tetete") due to 2 previous errors
主要语言
Rust
星标
5.6k
派生
220
PR 合并指标
30 天内没有已合并 PR

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

dtolnay/thiserror 的其他 Issue

查看 dtolnay/thiserror 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。