Firewall and FirewallProfile: Add PolicyStore to allow targeting local group policy

未关闭
#428 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

@brajjan 已经在做这个了。

开始于 2022年9月3日。

  • #517 来自 @brajjan —— 已关闭,未合并
  • #518 来自 @brajjan —— 未关闭
  • #519 来自 @brajjan —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
38/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
停滞
技术栈
powershell
领域
networking

调研方向

首先定位 Firewall 和 FirewallProfile 资源及其 Get/Set/Test-TargetResource 函数,然后跟踪指定 helper 和 NetFirewall 命令的调用。检查在指定 PolicyStore 且规则存在或不存在时针对 Get-FirewallRule 的两个 Pester 测试。完成的标准是两个资源都支持以 persistentstore 为默认值的 PolicyStore,并且已覆盖列出的 helper、命令和测试路径。

由索引模型根据 Issue 内容生成。

描述

enhancement help wanted
Details of the scenario you tried and the problem that is occurring

Enable the "PolicyStore" parameter to be specified to permit targeting the local group policy store of the machine as well as the default persistent store when using both the Firewall and FirewallProfile resources

Verbose logs showing the problem

New Feature request

Suggested solution to the issue

Add "policystore" as a DSC property for both Firewall and FirewallProfile resources
Set the default value of the "policystore" parameter to be "persistentstore" to make it a non-breaking change and accommodate all existing configurations.
Add "policystore" parameter to

  • Get/Set/Test-TargetResource functions in both Resources
  • Get-FirewallRule and Get-FirewalRulleProperty helper functions in Firewall resource
  • Get/Set/New-NetFirewallRule commands in Firewall resource
  • Get/Set-NetFirewallProfile commands in FirewallProfile resource
The DSC configuration that is used to reproduce the issue (as detailed as possible)

New Feature request

The operating system the target node is running

Server 2016/2019 - New Feature request

Version and build of PowerShell the target node is running

New Feature request

Version of the DSC module that was used ('dev' if using current dev branch)

dev

I have made and tested the required changes and can happily submit a pull request with the updates to the code and localization strings.

I have also added two Pester tests to the Firewall resources for the helper function "Get-FirewallRule" when the -policystore is specified and the firewall rule is present/absent.

主要语言
PowerShell
星标
234
派生
92
PR 合并指标
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

dsccommunity/NetworkingDsc 的其他 Issue

查看 dsccommunity/NetworkingDsc 的全部 Issue

相似的 Issue

更多 Networking Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。