Firewall and FirewallProfile: Add PolicyStore to allow targeting local group policy
@brajjan 已经在做这个了。
开始于 2022年9月3日。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 38/100
- Issue 类型
- 功能
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- powershell
- 领域
- networking
调研方向
首先定位 Firewall 和 FirewallProfile 资源及其 Get/Set/Test-TargetResource 函数,然后跟踪指定 helper 和 NetFirewall 命令的调用。检查在指定 PolicyStore 且规则存在或不存在时针对 Get-FirewallRule 的两个 Pester 测试。完成的标准是两个资源都支持以 persistentstore 为默认值的 PolicyStore,并且已覆盖列出的 helper、命令和测试路径。
由索引模型根据 Issue 内容生成。
描述
Details of the scenario you tried and the problem that is occurring
Enable the "PolicyStore" parameter to be specified to permit targeting the local group policy store of the machine as well as the default persistent store when using both the Firewall and FirewallProfile resources
Verbose logs showing the problem
New Feature request
Suggested solution to the issue
Add "policystore" as a DSC property for both Firewall and FirewallProfile resources
Set the default value of the "policystore" parameter to be "persistentstore" to make it a non-breaking change and accommodate all existing configurations.
Add "policystore" parameter to
- Get/Set/Test-TargetResource functions in both Resources
- Get-FirewallRule and Get-FirewalRulleProperty helper functions in Firewall resource
- Get/Set/New-NetFirewallRule commands in Firewall resource
- Get/Set-NetFirewallProfile commands in FirewallProfile resource
The DSC configuration that is used to reproduce the issue (as detailed as possible)
New Feature request
The operating system the target node is running
Server 2016/2019 - New Feature request
Version and build of PowerShell the target node is running
New Feature request
Version of the DSC module that was used ('dev' if using current dev branch)
dev
I have made and tested the required changes and can happily submit a pull request with the updates to the code and localization strings.
I have also added two Pester tests to the Firewall resources for the helper function "Get-FirewallRule" when the -policystore is specified and the firewall rule is present/absent.
- 主要语言
- PowerShell
- 星标
- 234
- 派生
- 92
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
dsccommunity/NetworkingDsc 的其他 Issue
-
chore
难度 2/5 1-3 小时 新手友好度 72/100
dsccommunity/NetworkingDsc#544 ·
-
chore
难度 4/5 3-5 天 新手友好度 72/100
dsccommunity/NetworkingDsc#542 ·
-
chore
难度 3/5 1-2 天 新手友好度 68/100
dsccommunity/NetworkingDsc#543 ·
-
难度 2/5 1-3 小时 新手友好度 25/100
dsccommunity/NetworkingDsc#539 ·
-
难度 2/5 1-3 小时 新手友好度 25/100
dsccommunity/NetworkingDsc#538 ·
查看 dsccommunity/NetworkingDsc 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
aidev-iprokszin/ipcam-mcp#15 ·
-
难度 2/5 1 小时以内 新手友好度 65/100
qnikst/HaskellNet#125 ·
-
scheduleGrant: a capped grant marks a still-backlogged connection inactive (LteSchedulerEnb.cc:403).未关闭
难度 2/5 1-3 小时 新手友好度 66/100
-
难度 1/5 1 小时以内 新手友好度 82/100
Juniper/ansible-junos-stdlib#909 ·
-
bug enchantments Java Edition protocol
难度 2/5 1-3 小时 新手友好度 80/100
Pumpkin-MC/Pumpkin#4465 ·
维护者通常 1 天内回复