`allows ref struct` type parameters accept `'T byref` arguments: `int byref seq` compiles on net9.0+ and fails with `TypeLoadException`

未关闭
  • 哪里不对？
#20,936 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 2 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
52/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
fsharp
领域
compilers

调研方向

Read src/Compiler/Checking/PostInferenceChecks.fs, especially ByrefTypeCheck.VisitTyconRef and the PermitByRefType branches. Compare the byref and byref-like checks with the repro in the issue, then build the library targeting net9.0 and verify the expected FS3300 errors for f and g. Done when managed-pointer type arguments are rejected while byref-like structs remain permitted.

由索引模型根据 Issue 内容生成。

描述

Bug Needs-Triage Regression

Since F# 9 (#17706, consuming allows ref struct generic parameters) the post-inference byref checks skip a type argument entirely when its type parameter is allows ref struct. That lets managed-pointer types through (byref<T>, inref<T>, outref<T>), not only byref-like structs. On .NET 9 and later IEnumerable<T>, IEnumerator<T>, Func<> and Action<> carry AllowByRefLike, so seq<byref<int>> type-checks, IL is emitted, and the runtime rejects it at type load.

Repro steps

module Lib
let f xs = for x: int byref in xs do ()  // inferred xs: seq<byref<int>>, no error
let g (xs: seq<byref<int>>) = ()         // no error
let h (xs: byref<int> list) = ()         // FS3300, as expected
  1. Put the file in a library project with <TargetFramework>net9.0</TargetFramework> (same with net10.0 and net11.0) and run dotnet build. Only h reports an error.
  2. Reflect over Lib.g in the built assembly:
System.TypeLoadException: The generic type 'System.Collections.Generic.IEnumerable`1' was used with an invalid instantiation in assembly 'System.Private.CoreLib, Version=11.0.0.0'
  1. In dotnet fsi, let f xs = for x: int byref in xs do () prints val f: xs: byref<int> seq -> unit. Any use of f then fails:
error FS0193: internal error: Unable to load one or more of the requested types.
The generic type 'System.Collections.Generic.IEnumerable`1' was used with an invalid instantiation

Expected behavior

The same errors as with net8.0, where the file reports FS3300 for f, g and h and FS0412 at the loop. allows ref struct permits byref-like structs such as Span<T>; it never permits managed pointers (ECMA-335 II.9.4).

Actual behavior

f and g compile on net9.0, net10.0, net11.0 and in fsi. The output fails at type load.

Cause

src/Compiler/Checking/PostInferenceChecks.fs, ByrefTypeCheck.VisitTyconRef: the guard if not (ctx.TyparAllowsRefStruct()) then wraps all four PermitByRefType branches, including the isByrefTyconRef test in the SpanLike branch and the byref part of isByrefLikeTyconRef in the other branches. The anti-constraint should relax only the byref-like test; a byref type argument must still be an error. Introduced in bb027e1378.

Known workarounds

None needed: the code cannot run. Found while writing fslang-design#845 (RFC FS-1348), whose compatibility section assumed this form is always a compile-time error.

Related information

  • Windows 11, .NET SDK 11.0.100-rc.1.26420.103 and its F# compiler; net8.0 build of the same file reports the errors.
  • On .NET 11: typedefof<seq<_>>.GetGenericArguments().[0].GenericParameterAttributes = Covariant, AllowByRefLike.
主要语言
F#
星标
4.3k
派生
883
平均合并
3 天 10 小时
30 天内合并 PR
95

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

dotnet/fsharp 的其他 Issue

查看 dotnet/fsharp 的全部 Issue

相似的 Issue

更多 Compilers Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。