Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Release-only wrong result in integer `for` loop: local bound inside loop range expression clobbers a local slot

未关闭
#20,732 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 3 天内回复

@rspeele 已经在做这个了。

开始于 2026年10月8日。

  • #20733 来自 @rspeele —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
35/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
领域
compilers

调研方向

Start by locating GenIntegerForLoop in the F# compiler and inspect how it allocates local slots while evaluating loop bounds; the issue identifies that as the source of the clobbering. Use the three repro scripts in the report with optimization both disabled and enabled, especially the case that loops forever. Done when optimized execution matches the unoptimized results without clobbering locals.

由索引模型根据 Issue 内容生成。

描述

Bug Needs-Triage

Release-only wrong result in integer for loop: local bound inside loop range expression clobbers a local slot

Repro steps

//// repro.fsx ////
// dotnet fsi --optimize- repro.fsx   prints: 100
// dotnet fsi --optimize+ repro.fsx   prints: 50

let f k =
    k + (for _ in max 0 (k - 50) .. 0 do stdout.Write ""
         0)

printfn "%d" (f 100)

Expected behavior

The behavior without optimization is correct. f k is equivalent to k+0, so f 100 should be 100.

Actual behavior

With optimization on, the generated IL spills k off the stack into a local variable slot, but then when evaluating the loop start expression, max needs a local to store k - 50.

GenIntegerForLoop puts that local in the same slot. That clobbers k.

In my first example the start expression is the culprit. But the end expression has the same problem when the optimizer rewrites a loop like for i in 0 .. arr.Length - 1 C#-style. The local can take the loop variable's own slot, and the loop never terminates. Example:

//// repro2.fsx ////
// dotnet fsi --optimize- repro2.fsx   prints: 0 1 2
// dotnet fsi --optimize+ repro2.fsx   prints: 0 0 0 0 0 ... forever

let f (xs: int[]) n =
                  // this could be any side-effect-free expr that binds a local
    for i in 0 .. (if max 0 (n - 1) > 0 then xs else xs).Length - 1 do
        printf "%d " i

f [| 1; 2; 3 |] 1

Known workarounds

Bind the loop's start and/or end to locals with let. Use for x in startVar .. endVar do instead of putting complex expressions directly inside the in _ .. _ part of the loop.

Related information

Windows 10, SDK 10.0.401, and reproduced on main at 3917a24af

This bug repros going back at least to SDK 6.0.428. But going from 10.0.202 to 10.0.401, it became more visible as it can affect some usages of Array.init as well. This is how I ran into it.

//// repro3.fsx ////
// dotnet fsi --optimize- repro3.fsx   prints: [|0; 1; 2|]
// dotnet fsi --optimize+ repro3.fsx   prints: [|2; 1; 0|]

let xs =
    Array.init 3 (fun k ->
        for _ in max 0 (2 - k) .. 0 do stdout.Write ""
        k)

printfn "%A" xs

I will follow up with a small PR to fix this.

Possibly related: dotnet/fsharp#20564 (different symptom, also stack saving around a branch)

主要语言
F#
星标
4.3k
派生
881
平均合并
3 天 22 小时
30 天内合并 PR
105

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

dotnet/fsharp 的其他 Issue

查看 dotnet/fsharp 的全部 Issue

相似的 Issue

更多 Compilers Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。