Apps configuration page scrolls to the bottom on load when a field hint contains a code block
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 2/5
- 预计耗时
- 1-3 小时
- 新手友好度
- 82/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- angular, javascript, typescript
调研方向
从指定的指令 core-web/apps/dotcms-ui/src/app/portlets/dot-apps/components/dot-apps-configuration-detail/directives/dot-apps-code-block.directive.ts 开始,追踪它如何创建并插入 DotCopyButtonComponent。为这条插入路径添加或查找一个单元测试。完成标准是:插入的复制按钮没有 autofocus 属性,代码仍能复制,并且满足验收标准。
由索引模型根据 Issue 内容生成。
描述
Problem Statement
When an App's configuration page loads, it scrolls down to the "Advanced Configuration (JSON)" field instead of staying at the top. Users land in the middle of the form and have to scroll back up to see the first fields. You can see it on the Content Analytics App.
The jump happens because the copy button inside the hint's code block gets focus by itself.
- The
dotAppsCodeBlocksdirective turns each code block in a markdown hint into a box with a copy button (DotCopyButtonComponent). It renders that button outside the page withcreateComponent()and then inserts it. - PrimeNG's
p-buttonaddsautofocus="true"to its inner<button>whenever itsautofocusinput is not set. ItsAutoFocusdirective only removes the attribute when it gets exactlyfalse, and an unset input arrives asundefined. - The browser focuses an element that is inserted into the page with
autofocusalready on it, and scrolls to it. Buttons that were already on the page don't trigger this. This one does, because it is inserted after being rendered.
This affects any App whose YAML puts a fenced code block in a field hint. The App YAML has no setting that controls this; the fix has to be in the frontend.
https://github.com/user-attachments/assets/67afb58c-9907-49c3-96e1-1bc5f36cc03a
Steps to Reproduce
- Go to Apps → Content Analytics and create a configuration for the System Host (
/dotAdmin/#/apps/dotContentAnalytics-config/create/SYSTEM_HOST). - Wait for the form to load.
- Notice that the page scrolls to "Advanced Configuration (JSON)".
- In DevTools,
document.activeElementis the code block's copy button and hasautofocus="true".
Acceptance Criteria
- An App configuration page opens scrolled to the top, even when a field hint contains a code block.
- Nothing in the hint's code block takes focus on page load.
- The copy button in the code block still shows and copies the code.
- A unit test covers that the copy button created by
dotAppsCodeBlockshas noautofocusattribute when it is inserted.
dotCMS Version
main (introduced with the code block directive in #37897).
Severity
Low - Minor issue or cosmetic
Links
- PR that added the directive: #37897
- Directive:
core-web/apps/dotcms-ui/src/app/portlets/dot-apps/components/dot-apps-configuration-detail/directives/dot-apps-code-block.directive.ts - App descriptor where it shows up:
dotCMS/src/main/resources/apps/dotContentAnalytics-config.yml(thehintofadvancedConfig)
- 主要语言
- Java
- 星标
- 972
- 派生
- 493
- 平均合并
- 2 天 12 小时
- 30 天内合并 PR
- 237
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
dotCMS/core 的其他 Issue
-
OKR : Customer Support Team : Maintenance Type : Defect
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复
-
Opening content from Content Search replaces the "Search" breadcrumb in the new Edit Content screen未关闭dotCMS: New Edit Contentlet OKR : Customer Support Team : Falcon Type : Defect
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 2 天内回复
-
Escape the Binary field hint in the legacy content editor so an apostrophe doesn't break the field未关闭OKR : Customer Support Team : Maintenance Type : Defect
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 2 天内回复
-
dotCMS : Permissions OKR : Customer Support Team : Maintenance Type : Defect
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 2 天内回复
-
OKR : Customer Support Team : Maintenance Type : Defect
难度 2/5 1-3 小时 新手友好度 75/100
维护者通常 2 天内回复
相似的 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 70/100
it-at-m/Wahllokalsystem#3846 ·
维护者通常 2 天内回复
-
Area/Connector module/solace Priority/Low Type/Bug
难度 2/5 1-3 小时 新手友好度 77/100
ballerina-platform/ballerina-library#9849 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 65/100
Vakore/ZappierGames#327 ·
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
Radix number block generates NaN after switching a negative or decimal number to binary, octal or hex可能已有人在做 @matthewalberto 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 64/100
mit-cml/appinventor-sources#4246 · 1 条评论 ·
维护者通常 1 天内回复