[TODO]: Deprecate `TLS_LEVEL=intermediate`

未关闭
  • 哪里不对？
#3,892 0 条评论 1 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
25/100
Issue 类型
功能
描述清晰度
需要澄清
活跃度
停滞
技术栈
docker, shell
领域
devops, security

调研方向

先从 target/scripts/helpers/ssl.sh 的第 145-148 行附近开始，然后检查 TLS_LEVEL 文档以及 issue 中提到的 check-for-changes.sh 行为。在决定采用 legacy opt-in 还是仅提供文档指导之前，先查看 user-patches.sh 示例和链接的讨论；完成这项工作需要为 TLS_LEVEL 确定一致同意的迁移路径，并进行一致的实现或文档编写。

由索引模型根据 Issue 内容生成。

描述

area/features area/networking area/security kind/update service/dovecot service/postfix stale-bot/ignore
Description

Despite what the docs presently say for TLS_LEVEL, intermediate does not offer TLS 1.0/1.2 anymore:

https://github.com/docker-mailserver/docker-mailserver/blob/a815bf5ab44388baecb597a0b83f71872a2d34bc/target/scripts/helpers/ssl.sh#L145-L148

This was removed in #2945 but I have noticed that we have a user forking to carry a patch to revert back the support along with the required OpenSSL config.

From v17 (or perhaps v16 if someone wants to tackle it in time), we could add this support back via an alternative TLS_LEVEL=legacy or alternative opt-in like TLS_LEGACY=1.

I'm not sure if there is any value in us maintaining the separate intermediate list, the cipher lists could be unset back to defaults from Postfix/Dovecot. TLS_LEVEL would then be deprecated so that we only offer modern, as it really only exists for legacy requirements to use intermediate for broader compatibility 🤷‍♂️

We don't presently document to users how to bring back TLS <1.2 support. Instead of providing a legacy TLS opt-in feature, we could just document a solution with user-patches.sh? (if maintainers would prefer to avoid the burden of maintenance support in DMS for a niche feature catering to user convenience).

I did provide a user-patches.sh example, but note a caveat with how it may be undone by our check-for-changes.sh service being triggered.

UPDATE: A user requested how to configure for TLS 1.3 only. Mainly with the motivation of chasing a better score from a security scanning service however.

  • I've documented an answer, which relies upon TLS_LEVEL being set to an unsupported value to opt-out of cert updates causing check-for-changes.sh to trigger the TLS helper method that would overwrite their min protocol config changes (via user-patches.sh).
  • Might be worth referencing that advice in our docs. Technically with what is proposed above switching to TLS 1.3 only is simpler as there's no concern with cipher-list config. If TLS_LEVEL=modern becomes the implicit default, and TLS_LEGACY=1 were a separate feature, the check-for-changes.sh concern for user customization would no longer exist as only opt-in to TLS_LEGACY would interfere with such settings when certs are updated.
主要语言
Shell
星标
19.7k
派生
2.1k
平均合并
22 小时 39 分钟
30 天内合并 PR
8

环境准备

  • 提供 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

docker-mailserver/docker-mailserver 的其他 Issue

查看 docker-mailserver/docker-mailserver 的全部 Issue

相似的 Issue

更多 Shell/Bash Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。