We just switched to the new Proto library build rules in the [instrumentation-proto](https://github.com/google/instrumentation-proto) repository, by following the instructions at https://bazel.build/blog/index.html#protocol-buffers-in-bazel. Here is the pull request: https://github.com/google/instrumentation-proto/pull/26
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 25/100
- Issue 类型
- 缺陷
- 描述清晰度
- 需要澄清
- 活跃度
- 停滞
- 技术栈
- java
- 领域
- build-system
调研方向
首先,使用列出的 --javacopt 标志复现提供的命令 bazel build :stats-core_impl,并检查 WORKSPACE 中引用的 com_google_protobuf_java 目标。比较 instrumentation-proto 构建规则更改后的行为,并确定依赖项警告和 java_proto_library 的确切预期处理方式;只有在就该行为达成一致并完成验证后,该 issue 才算完成。
由索引模型根据 Issue 内容生成。
描述
We just switched to the new Proto library build rules in the instrumentation-proto repository, by following the instructions at https://bazel.build/blog/index.html#protocol-buffers-in-bazel. Here is the pull request: https://github.com/google/instrumentation-proto/pull/26
Then we updated a git submodule to bring the changes into instrumentation-java, as in this commit: https://github.com/sebright/instrumentation-java/commit/95a6691ea8705f28c9b8a7a7f6ce3fa9d6b1c692
We were building instrumentation-java with --javacopt=-Werror --javacopt=-Xlint:all in CI. After the change, we started getting many errors that seemed to come from the com_google_protobuf_java http_archive target in our WORKSPACE file. Here is part of the list of errors from the failed Travis build:
ERROR: /home/travis/.cache/bazel/_bazel_travis/43f33de0ac8ec257b07378061caba359/external/com_google_protobuf_java/BUILD:553:1: Java compilation in rule '@com_google_protobuf_java//:protobuf_java' failed: Worker process sent response with exit code: 1.
external/com_google_protobuf_java/java/core/src/main/java/com/google/protobuf/AbstractMessage.java:55: warning: [rawtypes] found raw type: AbstractMessageLite
extends AbstractMessageLite
^
missing type arguments for generic class AbstractMessageLite<MessageType,BuilderType>
where MessageType,BuilderType are type-variables:
MessageType extends AbstractMessageLite<MessageType,BuilderType> declared in class AbstractMessageLite
BuilderType extends Builder<MessageType,BuilderType> declared in class AbstractMessageLite
external/com_google_protobuf_java/java/core/src/main/java/com/google/protobuf/AbstractMessage.java:250: warning: [rawtypes] found raw type: List
List list1 = (List) value1;
^
missing type arguments for generic class List<E>
where E is a type-variable:
E extends Object declared in interface List
The full command was:
bazel build :stats-core_impl --javacopt=-Werror --javacopt=-Xlint:all --javacopt=-Xlint:-cast --javacopt=-Xlint:-deprecation --javacopt=-Xlint:-try --verbose_failures
(We were already suppressing some other warnings.)
The full log is at https://travis-ci.org/sebright/instrumentation-java/jobs/212241166 .
Bazel version:
Build label: 0.4.5
Build target: bazel-out/local-fastbuild/bin/src/main/java/com/google/devtools/build/lib/bazel/BazelServer_deploy.jar
Build time: Thu Mar 16 12:19:38 2017 (1489666778)
Build timestamp: 1489666778
Build timestamp as int: 1489666778
I expected bazel to not fail the build in this case, for two reasons:
com_google_protobuf_javais only a dependency of the project. I think there should be a way to only fail if warnings come from the targets in theBUILDfile. (Is there already an option that does that?)java_proto_libraryshouldn't cause errors, because it is a built-in build rule.
/cc @bogdandrutu
Originally posted by @sebright in https://github.com/bazelbuild/bazel/issues/2699 s-out/
antlr3/
contrib/
Documentation/
e2e-tests/
java/
javatests/
lib/
modules/
plugins/
polygerrit-ui/
prolog/
prologtests/
proto/
resources/
tools/
webapp/
polymer-bridges
.bazelignore
.bazelproject
.bazelrc
.bazelversion
.editorconfig
.git-blame-ignore-revs
.gitignore
.gitmodules
.gitreview
.mailmap
.pydevproject
.zuul.yaml
BUILD
COPYING
INSTALL
Jenkinsfile
package.json
README.md
SUBMITTING_PATCHES
version.bzl
web-dev-server.config.mjs
WORKSPACE
yarn.lock
- 主要语言
- TypeScript
- 星标
- 3k
- 派生
- 461
- 平均合并
- 18 分钟
- 30 天内合并 PR
- 5
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
devcontainers/cli 的其他 Issue
-
难度 1/5 1 小时以内 新手友好度 92/100
devcontainers/cli#1203 ·
-
难度 1/5 1-3 小时 新手友好度 68/100
devcontainers/cli#1178 · 1 条评论 ·
-
难度 5/5 一周以上 新手友好度 25/100
devcontainers/cli#1308 ·
-
难度 3/5 1-2 天 新手友好度 78/100
devcontainers/cli#1307 · 1 条评论 · 1 个 reaction ·
-
难度 4/5 3-5 天 新手友好度 55/100
devcontainers/cli#1305 ·
查看 devcontainers/cli 的全部 Issue
相似的 Issue
-
bug(cli): hapi doctor inline-media prints a fabricated B:\ helper-script path in packaged installs 未关闭
难度 2/5 1-3 小时 新手友好度 70/100
-
Crush 未关闭
难度 1/5 1 小时以内 新手友好度 85/100
catppuccin/catppuccin#3125 ·
-
难度 1/5 1 小时以内 新手友好度 90/100
ElementsProject/cln-application#167 · 1 条评论 · 1 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 75/100
Quantco/pnpm-licenses#17 ·
-
难度 2/5 1-3 小时 新手友好度 75/100