Migrating 0.14 externally stored blobs and attachments leaves columns that 2.x cannot read
维护者通常 6 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- mysql, python
调研方向
Start with src/datajoint/migrate.py, src/datajoint/hash_registry.py, and the migration guide at how-to/migrate-to-v20.md; trace migrate_external, migrate_external_pointers_v2, migrate_filepath, and the verification functions. The report identifies failures across legacy path and hash conversion, column comments, and verification. Done means the documented migration lets 2.x fetch legacy blob and attachment values and completes its checks.
由索引模型根据 Issue 内容生成。
描述
After the documented migration of a 0.14 schema, columns declared blob@store or attach@store cannot be fetched in 2.x, although the migration reports success.
Found on master (eefe74b4) with MySQL, on a schema laid out as 0.14.6 lays it out: an ~external_legacy table, and a binary(16) column signal with the comment :blob@legacy:raw signal, whose blob file is at {location}/{database}/ec/88/<hash hex>.
What happens
migrate_external(schema, dry_run=False)fills the new column with{"url": null, "hash": "EC88A4468AB852D319309178A2E34955", "size": 109}urlis built frome.filepath(migrate.py#L1096-L1104). 0.14 leavesfilepathNULL for blobs and attachments, because their path is derived from the hash.- The value has no
pathkey and nostorekey. - The hash is the 32-digit hex value, not the 26-character base32 hash that 2.x uses.
migrate_external(schema, dry_run=False, finalize=True)writes the column comment as:blob@legacy:(migrate.py#L1004), not:<blob@legacy>:. The heading then reads the column as plainjson, andfetch1("signal")returns the dict above instead of the array.- Correcting the comment by hand to
:<blob@legacy>:doesn't help:fetch1then raisesKeyError: 'path', becauseget_hashreadsmetadata["path"](hash_registry.py#L284-L293).- With a
pathadded as well, it raisesHash mismatch: expected EC88A446…, got 5sekiruk….
No later step rewrites these rows. analyze_columns and migrate_columns skip the column as external storage.
Related defects in the same flow
migrate_external_pointers_v2, Option A in the migration guide:- On the 0.14
binary(16)column it fails withDataError 1406: Data too long for column. - With the column widened, it writes
{"path": null, "hash": "<32 hex digits>", ...}with nostore, which fails the same way when read.
- On the 0.14
migrate_filepathfinds no columns._find_filepath_columnslooks forDATA_TYPE = 'varchar'(migrate.py#L878-L882), but 0.14filepath@storecolumns arebinary(16).verify_external_integrityraisesTypeErroron blob rows, fromos.path.join(location, None)(migrate.py#L1350).verify_schema_v20always raisesTypeError: not enough arguments for format stringon MySQL. Its query has an unescapedLIKE '%blob'and also takes arguments (migrate.py#L2128).- The migration guide (
how-to/migrate-to-v20.md) finalizes withmigrate_external(schema, finalize=True). That runs with the defaultdry_run=Trueand changes nothing.
Expected
After the documented steps, a 0.14 blob@store or attach@store column returns its values in 2.x.
Suggested fix
- Build each path the way 0.14 derived it from the hash,
{database}/{subfolders}/{hash hex}, with the attachment name appended for attachments. - Write
{path, store, size, hash}, and let reads accept the legacy hex hash or skip the check for it. - Write the comment as
:<codec@store>:. - Match
binary(16)filepath columns. - Escape
%in theverify_schema_v20query. - Handle a NULL
filepathinverify_external_integrity. - Pass
dry_run=Falsein the guide's finalize example.
- 主要语言
- Python
- 星标
- 198
- 派生
- 103
- 平均合并
- 6 天 1 小时
- 30 天内合并 PR
- 10
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
datajoint/datajoint-python 的其他 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
datajoint/datajoint-python#1703 ·
维护者通常 6 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
datajoint/datajoint-python#1702 ·
维护者通常 6 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 78/100
datajoint/datajoint-python#1701 ·
维护者通常 6 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 74/100
datajoint/datajoint-python#1691 ·
维护者通常 6 天内回复
-
dependencies needs-discussion
难度 2/5 1-3 小时 新手友好度 68/100
datajoint/datajoint-python#1687 ·
维护者通常 6 天内回复
查看 datajoint/datajoint-python 的全部 Issue
相似的 Issue
-
needs-triage
难度 1/5 1-3 小时 新手友好度 85/100
gke-labs/kube-agents#6620 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 75/100
open-webui/open-webui#34719 · 2 条评论 ·
维护者通常 1 天内回复
-
cognition
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
One non-object JSON record makes the session catalog exit可能已有人在做 @he-yufeng 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 68/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 78/100
collabnix/awesome-mcp-lists#433 ·
维护者通常 4 天内回复