JSON path equality against a non-string value: silently empty on MySQL, raises on PostgreSQL
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 75/100
调研方向
Start in condition.py around prep_value at line 336, then trace adapter.json_path_expr for the MySQL and PostgreSQL implementations. Reproduce the listed restrictions against both backends and add regression coverage for string, integer, and boolean values. Done means JSON-path comparisons behave consistently across backends and never silently return wrong rows.
由索引模型根据 Issue 内容生成。
描述
Table & {"json_attr.field": value} only behaves correctly when value is a string. A Python bool returns the wrong answer on MySQL and raises on PostgreSQL; a Python int raises on PostgreSQL.
Sibling of #1563 — same root (JSON extraction yields text), different side: that one is the :type annotation on projection, this one is the Python value on restriction.
Repro
@schema
class E(dj.Manual):
definition = """
name : varchar(32)
---
s : json
"""
E.insert([
{"name": "a", "s": {"vendor": "Acme", "ch": 64, "cal": True}},
{"name": "b", "s": {"vendor": "Other", "ch": 16, "cal": False}},
])
Each row should select ['a']:
| restriction | MySQL 8.0 | postgres:15 |
|---|---|---|
& {"s.vendor": "Acme"} |
['a'] |
['a'] |
& {"s.ch": 64} |
['a'] |
UndefinedFunction: operator does not exist: text = integer |
& {"s.ch": "64"} |
['a'] |
['a'] |
& {"s.cal": True} |
[] |
UndefinedFunction: operator does not exist: text = boolean |
& {"s.cal": "true"} |
['a'] |
['a'] |
The MySQL boolean row is the serious one: no error, no rows, and the natural reading of an empty result is "nothing is calibrated."
Cause
adapter.json_path_expr yields json_value(...) / jsonb_extract_path_text(...), both of which return text. prep_value (condition.py:336) then renders the Python value by its own type, so the comparison becomes text = <non-text>:
- PostgreSQL refuses the comparison outright.
- MySQL coerces for numerics, which is why
64happens to work, but compares the extractedtrueagainst1for a bool and matches nothing.
The asymmetry is invisible to a user: the same expression is correct, wrong, or an error depending on the value's Python type and the backend.
Suggested fix
On the JSON-path branch of prep_value, render the comparison value as text — or cast the extraction to the value's type — so that True, 64 and "Acme" all behave the same way on both backends.
Whichever way, a bool must not silently match nothing. If a given comparison cannot be made portable, raising is acceptable; returning the wrong rows is not.
Documentation
This is almost certainly why tutorials/advanced/json-type.ipynb teaches "Filtering on JSON Content — fetch then filter in Python" and lists "Filter in Python" as an inherent property of JSON in its Design Guidelines. Server-side filtering does work, with the value passed as a string; the tutorial's advice reads as a limitation of the type rather than of this behavior. Worth revisiting together.
- 主要语言
- Python
- 星标
- 197
- 派生
- 98
- 平均合并
- 1 天 23 小时
- 30 天内合并 PR
- 6
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
datajoint/datajoint-python 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 76/100
datajoint/datajoint-python#1539 · 3 条评论 ·
-
bug
难度 4/5 3-5 天 新手友好度 68/100
datajoint/datajoint-python#1563 ·
-
enhancement
难度 5/5 一周以上 新手友好度 35/100
datajoint/datajoint-python#1562 · 2 条评论 ·
-
bug
难度 3/5 1-2 天 新手友好度 75/100
datajoint/datajoint-python#1561 · 1 条评论 ·
-
enhancement
难度 4/5 3-5 天 新手友好度 45/100
datajoint/datajoint-python#1560 ·
查看 datajoint/datajoint-python 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
FuRongJun-1999/dsh-memory#56 ·
维护者通常 1 天内回复
-
Bug
难度 2/5 1-3 小时 新手友好度 76/100
pgadmin-org/pgadmin4#10503 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 85/100
521xueweihan/HelloGitHub#3857 ·
-
documentation
难度 2/5 1-3 小时 新手友好度 74/100
rai-opensource/spatialmath-python#235 ·
维护者通常 1 天内回复
-
needs-ac
难度 2/5 1-3 小时 新手友好度 78/100
Ikalus1988/MisakaNet#2845 ·
维护者通常 1 天内回复