Pedal bounces can have different forms all within one PedalMark spanner
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
The payload names only the PedalBounce class, the enclosing PedalMark and its pedalForm attribute, so start by reading how PedalBounce and PedalMark are defined and where pedalForm is set on the mark. The proposal is to add a pedalForm field to PedalBounce so each bounce keeps its own form. The issue has been idle for over a year, has no assignee or linked pull request, and the author plans to implement it, so confirm with the maintainers before starting. Done means each bounce carries its own form and the attached score case renders correctly.
由索引模型根据 Issue 内容生成。
描述
Motivation
I neglected to allow for this possibility in my recent PR that implemented pedal marks. See the attached PDF, where sometimes you see Ped Ped Ped * (all one PedalMark with the 2nd and 3rd Peds being SymbolAlt bounces) and sometimes you see Ped *Ped *Ped * (all one PedalMark, with the *Peds being Symbol bounces). That's fine, but there is one PedalMark, starting in the 4th measure of the top system on page 120 (page 18 of the PDF), that has 4 *Ped (Symbol) bounces, and then a Ped (SymbolAlt) bounce in the 6th measure of the top system on page 121 (page 19 of the PDF), before finally stopping with a *.
Proposed implementation
I need to add a pedalForm field to PedalBounce, so I can set each PedalBounce form appropriately, rather than the current method of using the enclosing PedalMark's pedalForm to note the form of all the bounces within the PedalMark.
Intent
[ ****] I plan on implementing this myself.
[ ] I am willing to pay to have this feature added.
[ ] I am starting a discussion with the hope that community members will volunteer their time to create this. I understand that individuals work on features of interest to them and that this feature may never be implemented.
- 主要语言
- Python
- 星标
- 2.6k
- 派生
- 459
- 平均合并
- 12 小时 38 分钟
- 30 天内合并 PR
- 46
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
cuthbertLab/music21 的其他 Issue
-
enhancement
难度 2/5 1-3 小时 新手友好度 68/100
cuthbertLab/music21#2088 ·
维护者通常 1 天内回复
-
MusicXML import drops piano-family MIDI programs when the instrument name isn't recognized可能已有人在做 @Krishna221308 于 4 天前认领。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
cuthbertLab/music21#2084 · 6 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
cuthbertLab/music21#2055 · 3 条评论 ·
维护者通常 1 天内回复
-
Slur bezier-x/y from start element gets overwritten by stop element's values可能重新可做 @bingliscodes 于 23 天前认领，目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
cuthbertLab/music21#2019 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 62/100
cuthbertLab/music21#1714 ·
维护者通常 1 天内回复
查看 cuthbertLab/music21 的全部 Issue
相似的 Issue
-
changelog investigate
难度 2/5 1-3 小时 新手友好度 67/100
ramnes/notion-sdk-py#433 ·
-
docs pkg:core
难度 1/5 1 小时以内 新手友好度 84/100
pydantic/pydantic-ai#11929 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
intake/intake-esm#789 ·
-
难度 2/5 1-3 小时 新手友好度 82/100
MemMachine/MemMachine#1877 ·
维护者通常 3 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
openedx/openedx-authz#579 ·
维护者通常 1 天内回复