Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Musicxml import parses only first `<score-instrument>` for a part

未关闭
  • 哪里不对？
#1,696 3 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
冷清
技术栈
python
领域
data

调研方向

Start by reproducing with the attached BasicRockBeat.musicxml, using the script in the issue to print each note's getInstrument().instrumentId, which currently returns None. The MusicXML import code is the entry point, and the work is to read every score-instrument in a score-part and match each note to its instrument id. Done means each drum note reports its own instrument ID (such as P1-I36) and name, and chords get the right instrument per note. The maintainer notes say the issue is unlikely to be addressed soon, so confirm scope before starting.

由索引模型根据 Issue 内容生成。

描述

percussion

music21 version

9.1.0

Problem summary

When importing MusicXML files which contain parts with Drumsets (which use multiple instruments), it's impossible to tell what instrument which note belongs to.

music21 seems to only read the first <score-instrument> section of a <score-part>, and it doesn't seem to read the <instrument id="..."/> section of each <note>. This behaviour loses most of the drum note information, i.e. which actual drum to hit (.displayName is quite insufficient as many different drums can be notated on the same staff position, and each score can use different drum-to-staff mappings).

Steps to reproduce

I'm attaching a very basic MusicXML file which contains a basic drum rock beat. This file was produced by MuseScore 4.2.1.
The file contains a single drumset part with a single measure with:

  • a quarter-note chord of closed hi-hat together with the bass drum,
  • a quarter-note of closed hi-hat
  • a quarter-note chord of closed hi-hat together with the snare,
  • a quarter-note of closed hi-hat again.

First, ungzip the file in shell:

gzip -d BasicRockBeat.musicxml.gz

Then, in Python:

import music21

brb = music21.converter.parse('BasicRockBeat.musicxml')

# try to print note instruments
for note in brb.flatten().notes:
    instr = note.getInstrument()
    instr_id = instr.instrumentId
    print(f'ID {instr_id}: {instr}')

# first "note" is actually a chord. Maybe there's an instrument hidden somewhere in the notes?
first_chord_first_note = brb.flatten().notes[0].notes[0]
instr = first_chord_first_note.getInstrument()
instr_id = instr.instrumentId
print(f'ID {instr_id}: {instr}')

Observe the following output:

ID None: P1: Drumset: Acoustic Bass Drum
ID None: P1: Drumset: Acoustic Bass Drum
ID None: P1: Drumset: Acoustic Bass Drum
ID None: P1: Drumset: Acoustic Bass Drum
ID None:

Expected vs. actual behavior

I'd expect each note to be assigned to the correct instrument.

At the very least I'd expect .getInstrument().instrumentId to point to the correct instrument ID (i.e. "P1-I36", "P1-I43" and so on).

Additionally, I'd expect there to be an easy way to get the instrument name as well, i.e. not just "Acoustic Bass Drum" for everything (which is actually a substring together with Drumset), but also "Closed Hi-hat", "Acoustic Snare", etc. I'd also like to be able to access the MIDI note number (currently .midiProgram is empty for that instrument, and .midiChannel is sometimes correctly 9, but only if the note is not in a chord.).

More information

My suggestion would be to fully parse the <score-instrument> sections of a <score-part>. Parsing <midi-instrument>s would be nice too, so that the user of the library could get at the <midi-channel>, <midi-program> and <midi-unpitched> values. Once that's done, the instruments could be properly assigned to <note>s using IDs, as per the MusicXML standard.

主要语言
Python
星标
2.6k
派生
459
平均合并
1 天 7 小时
30 天内合并 PR
40

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

cuthbertLab/music21 的其他 Issue

查看 cuthbertLab/music21 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。