**harm spine import errors out on unrecognized token

未关闭
  • 哪里不对？
#1,655 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
28/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
python
领域
data

调研方向

Start with the humdrum harm-token handling in music21/humdrum/harmparser.py, where the parser returns None for unrecognized tokens (around line 66), and reproduce by parsing the linked .krn file with converter.parse(format='humdrum'). Done means an unrecognized **harm token no longer raises, and the maintainers have settled whether the fix is a default object, an opt-out setting, or keeping the raw token string, since the issue lists all three without choosing. The thread has no replies and the issue is over three years old, so confirm the approach with a maintainer before writing code.

由索引模型根据 Issue 内容生成。

描述

music21 version

8.3.0

Problem summary

Steps to reproduce

import music21
path = 'https://raw.githubusercontent.com/jcdevaney/TAVERN/master/Beethoven/B068/Joined/B068_00_01a_a.krn'
score = music21.converter.parse(path, format='humdrum')   # raises type error

Expected vs. actual behavior
I would expect the **harm spine parser to either not run by default or to handle unrecognized symbols without raising an error. If running the parser remains the default, perhaps there could be a setting that lets us not run the parser.

More information
This was run on a mac m1. An easy fix would be to have some sort of handling of unrecognized chord symbols. This line currently returns None which is fine but the final result of an unrecognized token should be some kind of default or empty music21 roman object.
The reason the score linked to above doesn't process is because it encodes the duration information into the chord tokens as well which is a relatively common thing to do in humdrum. In my case, I am not even using the results of the HarmParser. Instead I use music21's tools for reading any spine and take the **harm tokens as they are. But even doing it this way does not work without editing the score to remove the durations and occasional other unrecognized tokens.
Ideally there would be:

  1. a default value for unrecognized tokens
  2. a way to omit automatic parsing of **harm spines
  3. a bit of a side-quest, but it seems like you should be able to access the original **harm token's string no matter how it eventually gets represented (like the .contents attribute of objects in spine.eventList)
主要语言
Python
星标
2.6k
派生
459
平均合并
6 小时 22 分钟
30 天内合并 PR
95

环境准备

在 Codespaces 中打开

在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

cuthbertLab/music21 的其他 Issue

查看 cuthbertLab/music21 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。