Support sus4 chords in root-finding algorithm
评估
调研方向
The payload names chord.Chord('F B- C E-').root(), which should return F rather than C, and a rootnessFunction() idea that favours adjacent intervals. It names no source files, so locate the root-finding code from the Chord.root() method. The issue is still a discussion without an agreed design, and a closed, unmerged pull request (#1988) is linked, so check that thread before starting. Done means that example returns F and the existing chord tests still pass.
由索引模型根据 Issue 内容生成。
描述
Motivation
sus4 chords are common enough that we could support them in the root-finding algorithm.
Feature summary
>>> from music21 import chord
>>> chord.Chord('F B- C E-').root() # expected F
<music21.pitch.Pitch C>
Proposed implementation
rootnessFunction() might possibly prefer adjacent values (e.g. having a fifth and seventh trumps having a third and a seventh), but this would need to be tested (makes less sense in the case of adjacent ninth and eleventh, etc.)
Intent
[?] I plan on implementing this myself.
[ ] I am willing to pay to have this feature added.
[x] I am starting a discussion with the hope that community members will volunteer their time to create this. I understand that individuals work on features of interest to them and that this feature may never be implemented.
Reported on m21 list Sept. 2023
- 主要语言
- Python
- 星标
- 2.6k
- 派生
- 459
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
cuthbertLab/music21 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
cuthbertLab/music21#2190 ·
-
难度 2/5 1-3 小时 新手友好度 62/100
cuthbertLab/music21#2189 ·
-
enhancement
难度 2/5 1-3 小时 新手友好度 68/100
cuthbertLab/music21#2088 ·
-
MusicXML import drops piano-family MIDI programs when the instrument name isn't recognized可能重新可做 @Krishna221308 于 11 天前认领，目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 72/100
cuthbertLab/music21#2084 · 6 条评论 ·
-
Slur bezier-x/y from start element gets overwritten by stop element's values可能重新可做 @bingliscodes 于 29 天前认领，目前没有进行中的 PR。 未关闭
难度 2/5 1-3 小时 新手友好度 75/100
cuthbertLab/music21#2019 · 3 条评论 ·
查看 cuthbertLab/music21 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 69/100
jejjohnson/gaussx#752 ·
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 85/100
521xueweihan/HelloGitHub#4270 ·
-
enhancement owner: den-haag
难度 2/5 1-3 小时 新手友好度 67/100
维护者通常 6 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
ok-oldking/ok-wuthering-waves#1828 ·
维护者通常 1 天内回复
-
lesson-submission pending-review
难度 1/5 1 小时以内 新手友好度 65/100
Ikalus1988/MisakaNet#4512 ·
维护者通常 1 天内回复