test(e2e): the history-jsonpath pin misses guard calls that do not start a line
维护者通常 2 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 3/5
- 预计耗时
- 1-2 天
- 新手友好度
- 76/100
调研方向
Start in internal/fluxcontract/snapshot_shape_test.go, reading TestChainsawSuitesReadHistoryThroughTheSharedName and its guardConsumers and scriptSteps helpers. Check how it scans run-kubernetes.sh and Chainsaw suites, then run the focused contract test. Done when calls after &&, || or ; are detected and shell command operations' -c arguments are checked as steps.
由索引模型根据 Issue 内容生成。
描述
The contract test that holds every guard caller to the shared history jsonpath only sees calls in two shapes, so a caller written another way goes unchecked. The test is TestChainsawSuitesReadHistoryThroughTheSharedName and its neighbours in internal/fluxcontract/snapshot_shape_test.go, extended to the Chainsaw suites in #4689.
The guardConsumers pattern is anchored to the start of a line. A call such as cond && helmrelease_has_remediation_cycle "$x", or one after ; or ||, is not matched, in run-kubernetes.sh or in a suite. Today the opensearch suite is the only suite caller, so the callers == 0 check would catch it there. A second suite written that way would pass silently.
scriptSteps walks Chainsaw script operations only. A command operation (entrypoint: sh, args: [-c, ...]) that runs the guard is not read at all. No suite uses one today.
The fix is to match a call after &&, || and ; as well, and to read the -c argument of a shell command operation as a step.
- 主要语言
- Go
- 星标
- 2.2k
- 派生
- 209
- 平均合并
- 3 天 12 小时
- 30 天内合并 PR
- 230
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
cozystack/cozystack 的其他 Issue
-
e2e: cozyreport lists a shared zpool twice and ships an empty zfs-pools.txt that does not say why未关闭triage/needs-triage
难度 2/5 1-3 小时 新手友好度 76/100
cozystack/cozystack#4809 · 1 个 reaction ·
维护者通常 2 天内回复
-
area/ci kind/bug triage/needs-triage
难度 2/5 1-3 小时 新手友好度 85/100
cozystack/cozystack#4806 · 1 条评论 · 2 个 reaction ·
维护者通常 2 天内回复
-
triage/needs-triage
难度 2/5 1-3 小时 新手友好度 78/100
cozystack/cozystack#4787 · 1 个 reaction ·
维护者通常 2 天内回复
-
kubernetes-nodes: raising minReplicas does not raise the MachineDeployment's replicas on upgrade未关闭triage/needs-triage
难度 1/5 1 小时以内 新手友好度 88/100
cozystack/cozystack#4786 · 1 个 reaction ·
维护者通常 2 天内回复
-
triage/needs-triage
难度 2/5 1-3 小时 新手友好度 82/100
cozystack/cozystack#4785 · 1 个 reaction ·
维护者通常 2 天内回复
查看 cozystack/cozystack 的全部 Issue
相似的 Issue
-
agent-research-recommend agent-review-finding chore
难度 2/5 1-3 小时 新手友好度 78/100
jordansmall/spindrift#4821 · 1 条评论 ·
维护者通常 1 天内回复
-
area:web
难度 2/5 1-3 小时 新手友好度 82/100
praetorianer777/GoTome#178 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
oracle/go-oracledb#105 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 84/100
-
难度 2/5 1-3 小时 新手友好度 70/100
维护者通常 1 天内回复