Refactor Connection credential and auth wiring

未关闭
#290 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

@jlrobins 已经在做这个了。

开始于 2026年11月17日。

  • #327 来自 @jlrobins —— 未关闭

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
backend

调研方向

Start by reading Connection.__init__ and the listed auth members and helpers in connection.py; trace the credential branch to see how API key, BYOIDC, and OAuth are resolved. Extract the auth responsibilities into a collaborator and update Connection to use it. Then consider the listed transport builders, service clients, user-agent and timeout properties, and endpoints; done when the behavior is preserved and the responsibilities are grouped as described.

由索引模型根据 Issue 内容生成。

描述

Connection.init is too large mostly due to figuring out credential-based logic.

  • the auth-mode members: _byoidc, _oauth, _oauth_provider, _reauth_policy, _global_credentials, _flink_auth, _surface_auth;
  • _auth_for, _send_with_reauth_policy and oauth_metrics;
  • ControlPlaneSurface, _SurfaceSpec and _basic_auth;
  • the module-level _resolve_flink_auth and _resolve_service_credentials;
  • the credential branch of init, roughly 150 of its 330 lines.

A small collaborator, say ConnectionAuth, would resolve the mode (API key, BYOIDC or oauth) once and expose flink_auth, auth_for(surface), send_policy and oauth_metrics. Connection would hold one attribute instead of seven, and the enum and spec dataclass would leave connection.py.

After doing the main work, then also consider the transport functionality to also spin out of class Connection: _build_dataplane_client, _build_controlplane_client, _service_clients, the user-agent and timeout properties, and both endpoints are a coherent group. It would fold naturally into the auth collaborator.

主要语言
Python
星标
6
派生
1
平均合并
21 小时 16 分钟
30 天内合并 PR
29

环境准备

这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

confluentinc/confluent-sql 的其他 Issue

查看 confluentinc/confluent-sql 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。