generate-fixtures drops a redirect on a route that also has a page
维护者通常 1 天内回复
已经有一个关联 PR 被合并了。
- #468 来自 @silverbackdan —— 已合并
评估
调研方向
Start with Fixture/Generator/Site/SiteReader::orderRedirects(), where the !isset($available[spl_object_id($route)]) check skips redirects on routes that also belong to a page, and check how $unresolvedRedirects is populated. Pull request #468 is already open against this issue, so review it before starting. Done means the generated scaffold sets the redirect after the routes exist, or the route is reported under could not be reproduced.
由索引模型根据 Issue 内容生成。
描述
silverback:api-components:generate-fixtures (2.0.0-alpha.22) silently leaves out a redirect when the redirecting route also belongs to a page. Nothing appears in the could not be reproduced list.
Example (smoking-and-alcohol-websites production)
| Route | Page | Redirects to |
|---|---|---|
/ (home) |
Home | /graphs |
/graphs (graphs) |
Graphs | /graphs/top-line-findings |
/resources (resources) |
Resources | /resources/latest-statistics |
The generated scaffold creates all three pages with their routes, but contains no $cwa->redirect() call and no other redirect. A site loaded from it serves an empty Home page at / instead of redirecting.
Cause
In Fixture/Generator/Site/SiteReader::orderRedirects(), only routes not already in $siteRoutes become pending redirects:
if (null !== $route->getRedirect() && !isset($available[spl_object_id($route)])) {
A page's own route is in $siteRoutes, so its redirect is skipped. It isn't added to $unresolvedRedirects either, so nothing gets reported.
Expected
The redirect is carried. For a route that is both a page's route and a redirect, the scaffold should set the redirect after the routes exist, for example in an onRoutesCreated() / afterRoutes() callback ($cwa->getRoute('home')->setRedirect($cwa->getRoute('graphs')), or a builder equivalent). Failing that, it should at least be listed under could not be reproduced.
Downstream workaround: a small fixture that depends on the generated scaffold and sets the three redirects when they're missing.
- 主要语言
- PHP
- 星标
- 32
- 派生
- 8
- 平均合并
- 1 小时 1 分钟
- 30 天内合并 PR
- 159
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
components-web-app/api-components-bundle 的其他 Issue
-
难度 5/5 一周以上 新手友好度 20/100
components-web-app/api-components-bundle#504 · 22 条评论 ·
维护者通常 1 天内回复
-
难度 5/5 一周以上 新手友好度 30/100
components-web-app/api-components-bundle#333 · 3 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
components-web-app/api-components-bundle#325 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 3/5 1-2 天 新手友好度 52/100
components-web-app/api-components-bundle#259 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 48/100
components-web-app/api-components-bundle#186 ·
维护者通常 1 天内回复
查看 components-web-app/api-components-bundle 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 84/100
nextcloud/integration_openai#446 ·
-
bug customer-reported
难度 2/5 1-3 小时 新手友好度 76/100
MagnaCapax/PMSS#1101 ·
维护者通常 5 天内回复
-
InvoiceSettled is answered 200 when the invoice cannot be re-fetched, so BTCPay never redelivers it未关闭
难度 2/5 1-3 小时 新手友好度 76/100
btcpayserver/woocommerce-greenfield-plugin#93 ·
维护者通常 1 天内回复
-
kind/bug status/triage
难度 2/5 1-3 小时 新手友好度 68/100
-
bug medium priority unconfirmed
难度 2/5 1-3 小时 新手友好度 68/100
filamentphp/filament#20760 · 1 条评论 ·
维护者通常 1 天内回复