Rolling upgrade: GitHub default-branch adoption can miss the first sync or an older replica's PATCH to main (#599 follow-up)
维护者通常 1 天内回复
评估
调研方向
Read PR #607 and the two rolling-upgrade cases described here, then inspect the relevant sync and PATCH handling code and its tests. Decide how to prevent both missed adoption and an older replica's explicit PATCH from being overwritten; verify the behavior for each case. The issue names no source files or test paths, so locate them from the PR.
由索引模型根据 Issue 内容生成。
描述
Problem
PR #607 adopts the GitHub default branch at a successful sync of a GitHub sync repo whose create omitted default_branch (#599). During a rolling upgrade from a release without this rule, two cases miss the upstream behavior. http-api.md documents both, and the PR's Codex round 1 raised both.
- A sync that an older worker runs does not adopt. The flag stays set, so the next sync by an upgraded worker adopts. Until that sync, the repo is on
main, and with no further trigger it stays there. - An older replica's
PATCH /repotomainbefore that sync writes nothing that differs from the create's placeholdermain. The next sync by an upgraded worker then replaces the caller's explicitmainwith the GitHub branch. A PATCH to any other branch is kept, because the adopt write requires the repo to still be onmain.
Possible fixes
- A fleet-version gate, like
OPENSTORAGE_SYNC_STEAL_LEGACY: an operator assertion that no older replica remains before creates set the flag. - A reconciliation sweep that schedules a sync for flagged repos with
success_count > 0. This covers case 1 only. - Deploy sequencing in the release notes: upgrade every replica before accepting GitHub sync creates.
Trigger
Act on this issue at the first report of a GitHub sync repo left on main after a rolling upgrade, or when a release that ships #607 is prepared (decide then whether the release notes need a sequencing note).
Refs #599
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high
- 主要语言
- Go
- 星标
- 0
- 派生
- 0
- 平均合并
- 6 小时 16 分钟
- 30 天内合并 PR
- 243
环境准备
- 提供 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
coder/openstorage 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 72/100
coder/openstorage#807 ·
维护者通常 1 天内回复
-
难度 4/5 3-5 天 新手友好度 49/100
coder/openstorage#806 ·
维护者通常 1 天内回复
-
api: merge/preview ignores strategy, squash and allow_unrelated_histories可能已有人在做 @ThomasK33 今天认领。 未关闭
难度 4/5 3-5 天 新手友好度 35/100
coder/openstorage#805 ·
维护者通常 1 天内回复
-
githttp: +import remote serves clone and fetch, and its pushes stay out of the normal branch list可能已有人在做 @ThomasK33 今天认领。 未关闭
难度 5/5 一周以上 新手友好度 20/100
coder/openstorage#804 · 2 条评论 ·
维护者通常 1 天内回复
-
api: branches/create ignores expected_target_sha, so a guarded create or move can overwrite a branch可能已有人在做 @ThomasK33 今天认领。 未关闭
难度 4/5 3-5 天 新手友好度 35/100
coder/openstorage#803 ·
维护者通常 1 天内回复
查看 coder/openstorage 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 86/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
coder/coder-logstream-kube#255 · 1 条评论 ·
-
[FEATURE]: 录入 AIDEV Agent Package v1 接入参考文档可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭kind/features
难度 2/5 1-3 小时 新手友好度 73/100
TencentBlueKing/bk-nodemgr#3991 ·
维护者通常 1 天内回复
-
meta
难度 2/5 1-3 小时 新手友好度 62/100
last9/last9-mcp-server#554 ·
维护者通常 1 天内回复