Hacktoberfest 2026:维护者为十月标记出来的 issue,仍然开放、适合新手。 浏览 Hacktoberfest issue

Uninstall does not terminate running desktop app process, blocking reinstall

未关闭 适合新手
#166 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
65/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
停滞
技术栈
csharp

调研方向

从 Installer/Program.cs 开始,检查 MSI 项目现有的 ServiceInstaller 生命周期以及 WixExtension.Util 的使用情况。在 Coder Desktop 运行时构建或运行卸载和重新安装流程,然后验证卸载期间桌面进程和 VPN 进程都已停止,并且应用在重新安装后能够正常启动。

由索引模型根据 Issue 内容生成。

描述

bug

Summary

Uninstalling Coder Desktop via the Control Panel "Uninstall a program" wizard completes successfully, but the Coder Desktop.exe process (and the VPN service background process) remain running in Task Manager. This causes reinstallation to silently fail — the app never launches again.

Root Cause

The MSI installer has no mechanism to close the running desktop app process during uninstall. The ServiceInstaller manages the Windows service lifecycle (StopOn = InstallUninstall_Wait, RemoveOn = Uninstall_Wait), but there is no corresponding WixCloseApplication or custom action to terminate the user-space desktop app.

After uninstall, the old Coder Desktop.exe process continues running and holds the AppInstance singleton key (Coder.Desktop.App via AppInstance.FindOrRegisterForKey). On reinstall and relaunch:

  1. The new instance calls AppInstance.FindOrRegisterForKey("Coder.Desktop.App")
  2. It finds the old (zombie) instance, so mainInstance.IsCurrent is false
  3. It calls RedirectActivationToAsync to the old instance
  4. The old instance's OnActivated receives a Launch activation kind, which hits the unhandled default case
  5. The warning activation for "Launch", which is unhandled is logged and nothing else happens
  6. The new instance exits, and the app appears to never start

Steps to Reproduce

  1. Install Coder Desktop and launch it (the app runs in the system tray)
  2. Uninstall via Control Panel → "Uninstall a program"
  3. Observe in Task Manager that Coder Desktop and Coder VPN Service background processes are still running
  4. Reinstall Coder Desktop and launch it
  5. The app never appears — no tray icon, no window
  6. Check the logs for: [WRN] activation for "Launch", which is unhandled

Expected Behavior

  • The uninstaller should terminate the running Coder Desktop.exe process before removing files
  • The VPN service should be fully stopped and removed
  • After reinstall, the app should launch normally

Suggested Fix

Add a WixCloseApplication element (from WixExtension.Util) to the MSI project targeting Coder Desktop.exe. This will gracefully close the running app process during uninstall/upgrade before files are removed. For example in Installer/Program.cs:

project.Include(WixExtension.Util);
project.WixSourceGenerated += doc =>
    doc.FindFirst("Package").AddElement(
        WixExtension.Util.ToXName("CloseApplication"),
        "Target=Coder Desktop.exe; CloseMessage=yes; RebootPrompt=no");

Created on behalf of @uzair-coder07

主要语言
C#
星标
29
派生
12
平均合并
4 小时 15 分钟
30 天内合并 PR
2

贡献指南

这个仓库没有索引到贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

coder/coder-desktop-windows 的其他 Issue

查看 coder/coder-desktop-windows 的全部 Issue

相似的 Issue

更多 C# Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。