diff: accepted text differs from :w in corner cases of 'fileformat' and 'fileformats'
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
调研方向
Start with the diff acceptance code and the neovim_writes oracle in tests/integration/diff_accept_crlf_spec.lua. Compare proposal splitting and joining against readfile and :w for the listed fileformat and fileformats cases, including cases 4 and 5 whose scope still awaits a maintainer decision. Done means accepted text matches :w across the reported cases and the integration tests cover them.
由索引模型根据 Issue 内容生成。
描述
The text that a split-layout diff accepts can differ from what :w writes for the same buffer in some corner cases of 'fileformat' and 'fileformats'. Each case below exists on main before #577 too. #577 fixes the common cases (CRLF proposals under the default 'fileformats', and an unedited proposal under any 'fileformats') and leaves these for a follow-up.
ff=macwith a CR inside a line::wwrites that CR as NL, the accepted text keeps it."a\rb\n"then:setlocal ff=macgives"a\rb\r", while:wgives"a\nb\r".mainjoined with LF, which is also wrong. Codex flagged this on #577 (diff.lua, "Translate embedded CR bytes before joining Mac lines").set ffs=unix,mac: Neovim reads, for example,"a\r\nb\r\r\n"as mac, but the diff never detects mac. In 24ff=macedit cases,main's answer equals a file-read oracle and #577's does not. Both differ from:wof the same buffer.- Empty proposal, then typed lines:
'eol'stays off (#542), soGoxgives"\nx", while:wof an empty file gives"\nx\n". 'fileformats'starting withdosand a proposal with no LF ("","a","a\r"): Neovim reads it as dos, the diff keeps unix, so a typed line gets LF where:wwrites CRLF.set ffs=dos(one entry): Neovim reads every file as dos, an LF file too. An LF or mixed proposal stays unix, so a typed line gets LF where:wof the file writes CRLF.
Fix direction: one function that decides 'fileformat' and splits the proposal the way readfile does (empty value: 'fileformat'; one entry: forced; several entries: dos unless a lone LF, mac when there are more CRs than LFs, the first entry when there is no LF), plus a join that translates CRs for mac. The neovim_writes oracle in tests/integration/diff_accept_crlf_spec.lua (#577) can be reused.
Evidence: a probe of 1860 cases per run on Neovim 0.12.3 and 0.8.0, under 'fileformats' unix,dos, dos,unix, unix, dos and unix,mac. Mismatches with :w left on #577 (on main): 144 (748), 184 (788), 192 (304), 516 (1104), 544 (608).
The maintainer agreed to defer items 1 and 3 (and item 2, which belongs to item 1) from the README verification run. Items 4 and 5, and item 6 in the comment below, were found later and still wait for the maintainer's decision: fix them in this run or defer them here.
Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: high
- 主要语言
- Lua
- 星标
- 3.2k
- 派生
- 223
- 平均合并
- 6 小时 7 分钟
- 30 天内合并 PR
- 210
环境准备
在浏览器里用你自己的 GitHub 账号启动这个项目的开发容器。
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 没有贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
coder/claudecode.nvim 的其他 Issue
-
needs-triage
难度 2/5 1-3 小时 新手友好度 78/100
coder/claudecode.nvim#588 ·
维护者通常 1 天内回复
-
needs-triage
难度 2/5 1-3 小时 新手友好度 72/100
coder/claudecode.nvim#587 ·
维护者通常 1 天内回复
-
bug needs-triage
难度 2/5 1-3 小时 新手友好度 72/100
coder/claudecode.nvim#313 ·
维护者通常 1 天内回复
-
needs-triage
难度 4/5 3-5 天 新手友好度 56/100
coder/claudecode.nvim#590 ·
维护者通常 1 天内回复
-
needs-triage
难度 4/5 3-5 天 新手友好度 56/100
coder/claudecode.nvim#589 ·
维护者通常 1 天内回复
查看 coder/claudecode.nvim 的全部 Issue
相似的 Issue
-
documentation night-shift
难度 1/5 1 小时以内 新手友好度 90/100
-
bug
难度 2/5 1-3 小时 新手友好度 82/100
nvim-telescope/telescope.nvim#3718 ·
维护者通常 1 天内回复
-
bug discord guide:leatherworking locale:enUS triage v0.3.6
难度 2/5 1-3 小时 新手友好度 67/100
维护者通常 1 天内回复
-
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 1 天内回复
-
Data Correction Forever
难度 2/5 1-3 小时 新手友好度 67/100
维护者通常 1 天内回复