Attendees can sign up on the waiting list more than once
还没有人认领这个 Issue。
评估
调研方向
从 workshops_controller 的 rsvp 方法开始，检查 user_attending_or_waitlisted? 判断及其周围的 if/else 流程。复现或跟踪重复提交候补名单的情况，包括快速点击，然后确保同一位参与者不能被多次添加到同一 workshop 的候补名单中。
由索引模型根据 Issue 内容生成。
描述
Description of the issue 📄
We have a coach who is on the waiting list for our next workshop 10 times. This has happened before where the student was on 3 times.
Screenshots 📷
Steps to fix 🛠
Check in the rsvp method in workshops_controller to see if the user is already waitlisted. I can see there is this code but it doesn't seem to always be working:
if user_attending_or_waitlisted?(@workshop, current_user)
return redirect_back fallback_location: root_path, notice: t('workshops.already_wish_to_attend')
end
It is within an if/else statement so maybe it isn't hitting this part, or the user is clicking on rsvp too quickly before the previous waiting list addition has been complete.
To do 📋
- Claim this issue (comment below, or assign yourself if you are part of the codebar org)
- Fork and clone the repository
- Update the relevant files. Follow the steps to fix section in this issue.
- Commit your changes as one commit. Use the title of this issue as your commit message
- Submit a pull request
- Mention this issue in the PR description by including it's number
- Have your pull request reviewed & merged by a codebar team member
- 主要语言
- Ruby
- 星标
- 104
- 派生
- 205
- 平均合并
- 1 天 8 小时
- 30 天内合并 PR
- 67
贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
codebar/planner 的其他 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
-
难度 4/5 3-5 天 新手友好度 48/100
-
难度 5/5 一周以上 新手友好度 25/100
-
难度 5/5 一周以上 新手友好度 35/100
-
good first issue performance
难度 3/5 1-2 天 新手友好度 78/100
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100
googleapis/google-api-ruby-client#28001 · 5 个 reaction ·
-
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 2/5 1-3 小时 新手友好度 70/100