release.yml duplication, dead manifest platforms, and platform cfg branches outside atlas_core::sys

未关闭
#317 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
5/5
预计耗时
一周以上
新手友好度
22/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
github-actions, python, rust

调研方向

Start with .github/workflows/release.yml and count the repeated Rust-install, apt and SOURCE_DATE_EPOCH blocks, since the composite action is the most self-contained piece. Then read scripts/generate-manifest.py around lines 81-82 to drop the never-built darwin entries, and compare install.rs, uninstall.rs, desktop.rs and update_core.rs against the atlas_core::sys rule before moving their cfg branches. The large test-file splits in self_update.rs, tests/mcp.rs, tests/hostd.rs must keep test counts identical; done is one install block, a manifest of only built platforms, and unchanged test totals. This is a tracking issue spanning several subsystems, so pick one bullet rather than the whole list.

由索引模型根据 Issue 内容生成。

描述

area: ci area: cli priority: 3 low status: confirmed type: chore

Roadmap item (tracking: #289). From a read-only code audit at main (9c32731); key claims re-checked in code where marked verified. [INFERENCE] = not observed at runtime.

Problem

  • release.yml repeats the Rust install block 6x, apt block 5x, SOURCE_DATE_EPOCH 9x.
  • scripts/generate-manifest.py:81-82 lists x86_64-apple-darwin, universal-apple-darwin, never built.
  • Platform cfg branches in 121 files under atlas-{cli,core,tui,host,desktop}/src; install.rs, uninstall.rs, desktop.rs, update_core.rs branch locally against the atlas_core::sys rule.
  • Largest files: self_update.rs 1803, tests/mcp.rs 1850, manager/tests.rs 1637, tests/hostd.rs 1664, atlas-desktop/src/main.rs 830.

Proposal

Composite action for release setup; delete dead platforms; move install/uninstall cfg behind atlas_core::sys; split the largest test files (keep test counts).

Acceptance

  • One Rust-install block and one epoch line in release.yml; manifest lists only built platforms; test counts equal before/after splits.
主要语言
Rust
星标
3
派生
1
平均合并
9 小时 51 分钟
30 天内合并 PR
310

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

codeatlasdev/atlas 的其他 Issue

查看 codeatlasdev/atlas 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。