Release integrity: sign SHA256SUMS; checksums today come from the same release

未关闭
#279 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
42/100
Issue 类型
功能
描述清晰度
描述清楚
活跃度
活跃
技术栈
github-actions, rust, shell
领域
release, security

调研方向

Start by reading crates/atlas-cli/src/commands/release.rs (lines 15-45) to see how the .sha256 asset is fetched and trusted, then the checksum-only check at desktop_linux.rs:150 and the unsigned SHA256SUMS/manifest.json writes in release.yml (710-716). The public-key embedding also touches install.sh, and docs/release.md needs the rotation section. Done means the two acceptance bullets pass: a tampered asset with a matching .sha256 is rejected by atlas update, atlas desktop and install.sh, and the workflow signs. Note this is a design decision (minisign vs cosign keyless) that should be agreed with maintainers before coding.

由索引模型根据 Issue 内容生成。

描述

area: ci area: installer priority: 2 normal status: confirmed type: feature

Linux roadmap item (tracking: #289). Evidence is from reading code at main (9c32731) and a hand test on Omarchy (Arch, Hyprland Wayland, AMD 680M, Mesa 26.2.5, AppImage 1.5.0-alpha.25). [INFERENCE] marks anything not observed directly.

Problem

crates/atlas-cli/src/commands/release.rs:15-45 downloads <asset>.sha256 from the same GitHub release it verifies; release.yml:710-716 writes unsigned SHA256SUMS/manifest.json; desktop_linux.rs:150 checks ELF magic only. A swapped release or compromised account passes every check (CLI update, install.sh, AppImage sync).

Proposal

Sign SHA256SUMS with minisign (or cosign keyless); embed the public key in the CLI and install.sh; verify before trusting any checksum. GitHub attestations are a complement, not a replacement (install.sh must not need gh). Document rotation.

Acceptance

  • A tampered asset with a matching .sha256 is rejected by atlas update, atlas desktop and install.sh.
  • Release workflow signs; key rotation documented in docs/release.md.
主要语言
Rust
星标
3
派生
1
平均合并
9 小时 51 分钟
30 天内合并 PR
310

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

codeatlasdev/atlas 的其他 Issue

查看 codeatlasdev/atlas 的全部 Issue

相似的 Issue

更多 Rust Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。