Modify Plugs.DataToAttributes to follow JSON API sideposting draft
还没有人认领这个 Issue。
评估
调研方向
从 issue 中引用的 DataToAttributes 代码开始,检查 JaSerializer.Params.to_attributes 如何处理 belongs-to 关系。在更改行为之前,先查看 JSON API sideposting draft 和 issue #1301。完成的标准是:array 关系使用 temp-id 标识符选择匹配的 included 记录,而 map 关系仍由 JaSerializer.Params.to_attributes 处理。
由索引模型根据 Issue 内容生成。
描述
Problem
Our current approach with included records is to simply assume they are related to the main record.
Based on the draft
- included record payloads should have
temp-idproperties if they are to be created. - the main record payload should have a relationship where the identifier is
%{data: [%{"temp-id" => "foo", "type" => "bar"} - the plug should get those identifiers, then replace the identifier payloads with the associated full payloads matched in included
Subtasks
- instead of just taking any
includedrecords and assuming they're relationships in the resulting params map,DataToAttributesshould parse therelationshipsmap first- the relationship where
datais a map is a belongs to and should be left alone. it's already handled byJaSerializer.Params.to_attributes - the relationship where
datais an array should be checked for identifiers withtemp-idkeys- each
temp-idshould be found in theincludedsection and added under the pluralized relationship key in the resulting map
- each
- the relationship where
An advantage of this is that we now are able to conclude it's definitely a has_many, so we do not need to explicitly specify this anymore.
References
The code this needs to modify is part of #1301 so this is blocked until that is merged.
- 主要语言
- Elixir
- 星标
- 234
- 派生
- 82
- PR 合并指标
- 30 天内没有已合并 PR
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
code-corps/code-corps-api 的其他 Issue
-
难度 5/5 一周以上 新手友好度 15/100
code-corps/code-corps-api#1385 ·
-
难度 3/5 1-2 天 新手友好度 25/100
code-corps/code-corps-api#1384 ·
-
难度 4/5 3-5 天 新手友好度 35/100
code-corps/code-corps-api#1383 · 2 条评论 ·
-
难度 3/5 1-2 天 新手友好度 35/100
code-corps/code-corps-api#1382 · 2 条评论 ·
-
Difficulty: Medium Skill: Elixir Time: 4 hours
code-corps/code-corps-api#1372 · 3 条评论 · 已指派 1 人 ·
查看 code-corps/code-corps-api 的全部 Issue
相似的 Issue
-
bug
难度 2/5 1-3 小时 新手友好度 65/100
-
难度 2/5 1-3 小时 新手友好度 75/100
agentjido/jido_harness#80 ·
-
难度 2/5 1-3 小时 新手友好度 70/100
sevenseacat/cinder#235 ·
-
bug
难度 2/5 1-3 小时 新手友好度 85/100
-
难度 2/5 1-3 小时 新手友好度 84/100
phoenixframework/phoenix#6847 ·