Comma escaping for text overlays is not working correctly

未关闭
#702 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
3/5
预计耗时
1-2 天
新手友好度
42/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
领域
api, backend

调研方向

首先运行 issue 中的 JavaScript 复现,并跟踪用于文本叠加的 Cloudinary URL 生成路径。检查逗号与引号、破折号、问号和百分号相比是如何进行转义的;完成的标准是逗号能够原样出现在渲染后的叠加层中,同时不破坏其他转义行为。

由索引模型根据 Issue 内容生成。

描述

Describe the bug in a sentence or two.

Adding text overlays with commas (,) on videos results in %2C escape sequences in the overlay.
Other characters like quotes, dashes, question marks, and percent are automatically handled correctly and appear correctly in the overlay.
Manually escaping the comma does not work either because the % is automatically escaped.

Issue Type (Can be multiple)

[ ] Build - Can’t install or import the SDK
[ ] Babel - Babel errors or cross browser issues
[ ] Performance - Performance issues
[x] Behaviour - Functions aren’t working as expected (Such as generate URL)
[ ] Documentation - Inconsistency between the docs and behaviour
[ ] Incorrect Types - For typescript users who are having problems with our d.ts files
[ ] Other (Specify)

Steps to reproduce

Create a text overlay on a video that contains a comma.

Sample code:

let transformations = [
    { width: 900, height: 900, crop: "fill" },
    { color: "#ffffff", 
        overlay: { 
            font_family: font, 
            font_size: 48, 
            text: "So, \"here\" & here are 10% special chars - right?", 
            text_align: "center" 
        }, 
        width: 800, crop: "fit" }, 
    { duration: 2.0 },
    { flags: "layer_apply", gravity: gravity, x: 0, y: 0.05, start_offset: 0.0, end_offset: 2.0 }
];
      
      
let namedVideoTransformation = "myTransformation";
await cloudinary.v2.api.create_transformation(namedVideoTransformation, {
    transformation: transformations,
});
videoUri = cloudinary.url("folder/video.mp4", {
    resource_type: "video",
    transformation: [namedVideoTransformation],
});

Error screenshots

Image

Versions and Libraries (fill in the version numbers)

Cloudinary_NPM SDK version 2.5.1
Node - 23.7.0
NPM - 10.9.2

主要语言
JavaScript
星标
672
派生
318
PR 合并指标
30 天内没有已合并 PR

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 有 Pull Request 模板
  • 没有贡献指南

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

cloudinary/cloudinary_npm 的其他 Issue

查看 cloudinary/cloudinary_npm 的全部 Issue

相似的 Issue

更多 JavaScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。