Possible scheme fields improvement
还没有人认领这个 Issue。
评估
调研方向
Start with the README example using Scheme!, get_field, and set_field_value, then read the scheme and field APIs that define how field references are created and checked. Explore whether compile-time field information can provide a non-optional FieldRef while preventing values from unrelated schemes from being passed. Done means the API addresses both concerns; the issue names no tests, so identify relevant coverage while reading the implementation.
由索引模型根据 Issue 内容生成。
描述
I noticed the readme example has a few unwraps that could probably be avoided. For example:
let scheme = Scheme! {
http.method: Bytes,
http.ua: Bytes,
port: Int,
}
.build();
// ...
ctx.set_field_value(scheme.get_field("http.method").unwrap(), "GET")?;
I played around a bit to see if the field information could be returned when defining the scheme. That information could then be used to get a non-optional FieldRef based on the fact we know such fields were defined at compile time. I created a fork to demonstrate the idea: https://github.com/tombailey/wirefilter/pull/1
Just to note, that fork is AI slop. It is not intended as a real patch
And the fork doesn't prevent set_field_value being called with a field from an unrelated scheme
- 主要语言
- Rust
- 星标
- 1.2k
- 派生
- 126
- 平均合并
- 12 小时 12 分钟
- 30 天内合并 PR
- 4
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
cloudflare/wirefilter 的其他 Issue
-
AlwaysListMatcher::match_value always returns false, contradicting its own doc comment可能已有人在做 @sean0407 于 10 天前认领。 未关闭
难度 1/5 1-3 小时 新手友好度 90/100
cloudflare/wirefilter#190 ·
-
难度 4/5 1-2 天 新手友好度 32/100
cloudflare/wirefilter#204 · 2 条评论 ·
-
CPrimitiveType (a repr(u8) enum) is received directly by value across the C ABI with no validation未关闭
难度 3/5 1-2 天 新手友好度 68/100
cloudflare/wirefilter#196 ·
-
难度 4/5 3-5 天 新手友好度 68/100
cloudflare/wirefilter#195 · 1 条评论 ·
-
难度 4/5 3-5 天 新手友好度 65/100
cloudflare/wirefilter#194 ·
查看 cloudflare/wirefilter 的全部 Issue
相似的 Issue
-
priority middle
难度 1/5 1 小时以内 新手友好度 62/100
KATO-Hiro/AtCoderClans#12940 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 83/100
维护者通常 1 天内回复
-
o8 next debug build aborts on Glass to Dark appearance switch (nil identifier messaged before check)未关闭bug
难度 2/5 1-3 小时 新手友好度 78/100
hurttlocker/o8#5112 ·
-
难度 2/5 1-3 小时 新手友好度 79/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复