Deprecate the natural keys parameters to `insert_data` and `bulk_insert_dicts`

未关闭
#574 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
48/100
Issue 类型
重构
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
database

调研方向

Start by locating insert_data, bulk_insert_dicts, and the PullRequest model, then trace the call sites that pass pr_natural_keys. Work out how the model exposes its natural keys and which tests cover these insertion paths. Done means the parameters are deprecated consistently and the tests verify natural keys are derived from PullRequest.

由索引模型根据 Issue 内容生成。

描述

needs-plan tech debt

The above also made me realize: There are multiple places we update the pull requests table, so any PR we would have submitted to address it in one place (in addition to the DB) would have been wrong.

Im realizing that this means the whole concept of passing in pr_natural_keys manually in each call to bulk_insert_dicts is super fragile and prone to not matching aross different call sites.

We should probably derive the natural keys from the PullRequest Object itself, so its consistent every time.

Originally posted by @MoralCode in #93

主要语言
Python
星标
17
派生
30
平均合并
6 小时 16 分钟
30 天内合并 PR
9

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

chaoss/CollectOSS 的其他 Issue

查看 chaoss/CollectOSS 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。