Add CI jobs to act as a sanity check for PRs containing database migrations

未关闭
#572 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
51/100
Issue 类型
功能
描述清晰度
基本清楚
活跃度
活跃
技术栈
python
领域
ci-cd, database

调研方向

Start by reading the repository’s CI configuration and database migration files to see how migrations are named and run. Add checks for duplicate migration numbers and imports from database models in new migrations. Done means pull requests containing migrations receive both checks, with clear failures when either rule is violated.

由索引模型根据 Issue 内容生成。

描述

devops

Database migrations are one of the parts of the codebase that recieves the most review scrutiny, most of it very rules-based and mechanical.

We can convert these into CI checks to focus reviews on the less mechanical parts (i.e. "how will this affect existing instances")

Some criteria to check new PRs for (if they contain a new database migration):

  • That the migration number is not duplicated with an existing migration (i.e. two PRs create migrations with the same next number) - although this may not be fully reliable, if one PR merges and the other doesnt get rebased, the check may not rerun.
  • Ensuring that there are no import statements that import anything from the database models (use of DB models should be minimal or nonexistent, and if there is a reason for it, the models should be copy pasted into the migration)
主要语言
Python
星标
17
派生
30
平均合并
6 小时 16 分钟
30 天内合并 PR
9

环境准备

从这里开始

  1. 先读完整个 Issue,再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库,在一个分支上完成修改。
  4. 提交 Pull Request,并在描述里引用这个 Issue 编号。

chaoss/CollectOSS 的其他 Issue

查看 chaoss/CollectOSS 的全部 Issue

相似的 Issue

更多 Python Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。