Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

Web: value={0} with a negative minimumValue renders the thumb at the minimum

未关闭 适合新手
  • 哪里不对？
#828 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

还没有人认领这个 Issue。

评估

难度
2/5
预计耗时
1-3 小时
新手友好度
78/100
Issue 类型
缺陷
描述清晰度
描述清楚
活跃度
活跃
技术栈
react-native, typescript
领域
frontend, web-dev

调研方向

从 package/src/RNCSliderNativeComponent.web.tsx 开始，重点查看第 81 行附近的初始状态以及第 163-171 行附近的重新同步 effect。复现提供的负最小值示例，然后验证显式值 value={0} 会渲染为零，而非受控情况不会意外重置。

由索引模型根据 Issue 内容生成。

描述

Environment

  • @react-native-community/slider: 5.2.1 (also present on main at the time of writing)
  • Platform: web (react-native-web 0.21.2)
  • react: 19.2.3 · react-native: 0.86.3 · Expo SDK 57
  • New architecture: yes (Expo newArchEnabled is unconditional in SDK 57) — but this is a web-only code path, so the architecture is not relevant

Description

On web, a slider rendered with value={0} and a negative minimumValue paints its thumb at the minimum instead of at zero.

The value itself is fine — onValueChange reports correctly, and every number the app derives from the slider is right. Only the thumb position is wrong, and it stays wrong until the user drags it, at which point it starts behaving. So the failure looks like a rendering quirk rather than a state bug, which makes it easy to dismiss.

It is quite easy to hit in practice: any bipolar control that rests at zero does. Mine is a turntable-style pitch fader (-8 … +8, resting at 0), which means it was wrong on every load.

Reproducible Demo

import Slider from '@react-native-community/slider';

// Thumb renders hard left. Expected: centred.
<Slider minimumValue={-8} maximumValue={8} value={0} />

// Both of these are fine, which isolates it to the value being exactly zero
// against a negative minimum:
<Slider minimumValue={-8} maximumValue={8} value={0.1} />
<Slider minimumValue={0}  maximumValue={16} value={8} />

Cause

Two things combine, both in package/src/RNCSliderNativeComponent.web.tsx.

1. The initial state is seeded with || (L81):

const [value, setValue] = React.useState(initialValue || minimumValue);

0 is falsy, so value={0} seeds the internal state at minimumValue rather than at 0.

This cannot be fixed with ?? alone, because value is already defaulted at the destructure (L55):

value: initialValue = 0,

so by the time that line runs, "no value prop" and value={0} are indistinguishable — both are 0.

2. The resync effect cannot recover it (L163-L171):

const lastInitialValue = React.useRef<number>(0);
// ...
if (initialValue !== lastInitialValue.current) {
  lastInitialValue.current = initialValue;
  const newValue = updateValue(initialValue);
  animationValues.val.setValue(newValue);
}

The ref starts at 0, so for initialValue === 0 the guard evaluates 0 !== 0 — false. The effect never runs and the wrong initial state is never corrected.

I appreciate the guard is deliberate; the comment above it explains that it exists because initialValue gets defaulted to 0 by Slider, and without it the value resets constantly when the slider is uncontrolled. Any fix wants to keep that property.

Suggested fix

Distinguish "no value prop" from value={0} by not defaulting at the destructure, and track the same distinction in the ref:

value: initialValue,                                    // no ` = 0`
// ...
const [value, setValue] = React.useState(initialValue ?? minimumValue);
const lastInitialValue = React.useRef<number | undefined>(initialValue);
// ...
if (initialValue !== undefined && initialValue !== lastInitialValue.current) {
  lastInitialValue.current = initialValue;
  const newValue = updateValue(initialValue);
  animationValues.val.setValue(newValue);
}

That keeps the uncontrolled case from being reset (the effect still does nothing when no value is passed) while letting an explicit value={0} through.

I have not sent a PR since the change touches the uncontrolled path and you will have a clearer view than I do of what that should do; happy to open one if the approach looks right.

Workaround

For anyone hitting this before it is fixed: shift the domain so zero is not the resting value, and convert at the boundary.

// fader units 0 … 2R, presented as -R … +R
<Slider
  minimumValue={0}
  maximumValue={range * 2}
  value={pitch + range}
  onValueChange={(v) => setPitch(v - range)}
/>

The only value that still lands on 0 is the control fully down, where minimumValue is also 0, so the falsy branch produces the correct result anyway.

主要语言
TypeScript
星标
1.4k
派生
295
30 天内没有已合并 PR

环境准备

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

callstack/react-native-slider 的其他 Issue

查看 callstack/react-native-slider 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。