Hacktoberfest 2026：维护者为十月标记出来的 issue，仍然开放、适合新手。 浏览 Hacktoberfest issue

iOS selector click taps a point resolved from a pre-tap capture, so a layout shift between capture and tap retargets it silently

已关闭
  • 哪里不对？
#3,354 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看

维护者通常 1 天内回复

还没有人认领这个 Issue。

评估

难度
4/5
预计耗时
3-5 天
新手友好度
25/100
Issue 类型
缺陷
描述清晰度
基本清楚
活跃度
停滞
技术栈
ios, typescript
领域
mobile

调研方向

Start with settleAppleOpen in packages/platform-apple/src/open-policy.ts, where the fixed post-open sleep fallback lives, and with the runtime-selector tap path that takes its point from the pre-tap capture. The issue asks you to pick one owning fix, so first settle the design, then update the guarantee cell in packages/contracts/src/interaction-guarantees.ts. Done means a fixture or live run where a moved target either gets tapped at its new location or fails with a typed reason, with warm click timing unchanged. Linked PR #3356 is already open, so check it before starting.

由索引模型根据 Issue 内容生成。

描述

Purpose

An iOS selector click taps the point it resolved from its own pre-tap snapshot. If the layout moves between that capture and the tap, the tap lands on whatever is now under the old point, and the click still reports success. Nothing re-checks where the target is at dispatch time.

Evidence

Main run 37815426076 (2026-10-08, iOS 26 lane), 01-settings.ad. Times are from the session runner.log:

open            postOpenObservation: unobservable  -> fixed POST_OPEN_SETTLE_MS sleep
17:41:31.77 COMMAND_ACCEPTED  command=snapshot        (click's pre-tap capture)
17:41:34.57 COMMAND_COMPLETED command=snapshot ok=1   (2.80 s capture)
17:41:35.56 SYNTHESIZED_DISPATCH kind=tap point=(201.0,319.0)   attempt 1 -> following wait failed
17:42:10.96 SYNTHESIZED_DISPATCH kind=tap point=(201.0,406.0)   attempt 2 -> passed

General was at y=319 in a capture taken about 0.5 s after open returned. On the settled root list it is at y=406, 87 pt lower. Attempt 1's tap probably hit the Apple Account band.

This alone does not prove the tap missed. In #2936 a failing first attempt tapped the settled (201,406) and its wait still failed, so a stale point is one cause among others. Diagnostic history: #2948.

Where it happens

  • settleAppleOpen (packages/platform-apple/src/open-policy.ts): when the bridge can't read the app, the open falls back to a fixed sleep. When the bridge does read it, observable only means the tree was readable, not that the layout is stable.
  • The runtime-selector path takes its tap point from the rect in the pre-tap capture. Neither the offscreen/nonHittable checks nor anything in the runner confirm that the node is still at that point when the tap goes out.

Required behavior

  • Choose one owning fix and justify it against the evidence. Candidates:
    • re-resolve or re-check the target's frame in the runner right before tapping;
    • require the target's frame to be stable across captures before tapping;
    • gate the first post-open interaction on the layout settling.
  • A bounded check must have a budget shorter than the click itself and must not add a capture to warm clicks whose layout is already stable.
  • A target that moved and can't be confirmed must fail with a typed reason, not tap the old point.
  • Update the guarantee cell this changes in packages/contracts/src/interaction-guarantees.ts.

Completion

  • A fixture or live run where the target moves between capture and tap either taps the new location or fails with a typed reason.
  • Warm click p50 on 01-settings.ad (about 2.6 s locally) does not regress.

Related: #3335 (click reports dispatch, not landing), #2948, #2491/#3328 (wait observation stall).

主要语言
TypeScript
星标
4.9k
派生
328
平均合并
12 小时 18 分钟
30 天内合并 PR
561

环境准备

  • 没有 Dockerfile 或 Docker Compose 文件
  • 没有 Pull Request 模板
  • 阅读贡献指南

从这里开始

  1. 先读完整个 Issue，再读项目的贡献指南。
  2. 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
  3. Fork 仓库，在一个分支上完成修改。
  4. 提交 Pull Request，并在描述里引用这个 Issue 编号。

callstack/agent-device 的其他 Issue

查看 callstack/agent-device 的全部 Issue

相似的 Issue

更多 TypeScript Issue

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。