Collocation: fold src/cli-schema into src/commands/schema, move batch-steps into src/commands/batch
维护者通常 1 天内回复
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 48/100
- Issue 类型
- 重构
- 描述清晰度
- 描述清楚
- 活跃度
- 活跃
- 技术栈
- typescript
调研方向
Start by inventorying src/cli-schema, src/commands/schema, src/cli/batch-steps.ts, and the import and documentation paths named in the issue. Rebase onto an up-to-date apex/module-shape-measures after resolving the noted command-suggestions conflict, then run the listed pnpm checks and unit tests. Done means no old path references remain, all checks pass apart from documented unrelated failures, and the coupling and legibility measurements are handed off.
由索引模型根据 Issue 内容生成。
描述
Purpose
Split out from #2677: the collocation plan posted there proposes a sequence of src/-touching file moves ("PR A/B/C") derived from the coupling/legibility measures that issue builds. Per a follow-up note, guard 9 on #2677 keeps that issue tooling-only (nothing under src//packages/ changes there), so the moves themselves belong in their own issue(s) rather than under #2677.
This issue tracks "PR A" from the plan: move 1 plus the bundled small move.
Scope
- Fold
src/cli-schema/*(8 production + 8 colocated test files) intosrc/commands/schema/*.cli-schemais a standalone zone withQ ≈ 0, out/in flow 30, touching 29 of 39 families, and reader-condition legibility in the high-30s/low-40s depending on measurement — the plan's clearest "wrongly-a-family" candidate. It exists only to render the command facetscommands/already owns (#2543 declared that direction). - Move
src/cli/batch-steps.tsintosrc/commands/batch/batch-steps.ts(its only relative import and only real importer already live undersrc/commands/). - Pure move, no behavior change: update every import site, the literal owner-files path in
src/cli/command-explain.ts, the layering model's zone ranking (folded files resolve to thecommandszone by directory, so the standalonecli-schemarank entry is dropped),fallow-baselines/health.json's path-keyed findings, and doc pointers (AGENTS.md,docs/agents/cli-flags.md).
Sequencing note
Per the same follow-up comment, this move should be rebased onto apex/module-shape-measures (the branch implementing #2677's Layer A/B tooling — pnpm coupling / pnpm legibility) so the before/after coupling and legibility numbers are attributable to the move alone, not confounded by the tooling landing separately.
At the time of writing, apex/module-shape-measures (86741f2) is 4 commits behind main, including #2665 (feat(cli): open --wait, flag suggestions, and refusals that name what to run), which also touches src/cli/parser/command-suggestions.ts — one of the files this move touches. Rebasing onto apex/module-shape-measures as-is produces a real conflict there (not just a mechanical one: apex is missing #2665's new suggestFlagFor/flag-suggestion code entirely, so the conflict isn't resolvable by picking a side without either dropping this move's import-path fix for that file or pulling in unrelated feature work). Rebasing cleanly needs apex/module-shape-measures refreshed against current main first.
Acceptance
- All import sites updated, no stray
cli-schemaor oldbatch-steps.tspath references -
pnpm lint,pnpm typecheck,pnpm format:check,pnpm check:layering,pnpm check:gate-manifestpass -
pnpm test:unitpasses (pre-existing unrelated failures excepted) - Rebased onto an up-to-date
apex/module-shape-measures, withpnpm couplingbefore/after numbers in the PR description - Base/head SHAs handed off for the
pnpm legibility(Jev) before/after measurement, per the offer in https://github.com/callstack/agent-device/issues/2677#issuecomment-5741660420
- 主要语言
- TypeScript
- 星标
- 5k
- 派生
- 334
- 平均合并
- 12 小时 29 分钟
- 30 天内合并 PR
- 663
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
callstack/agent-device 的其他 Issue
-
bug ready-for-agent
难度 2/5 1-3 小时 新手友好度 62/100
callstack/agent-device#3627 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 68/100
callstack/agent-device#1869 ·
维护者通常 1 天内回复
-
A session lost to a daemon takeover ("Replacing daemon … unreachable") answers the next request with AMBIGUOUS_MATCH when two simulators are booted可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭bug ready-for-agent
难度 4/5 3-5 天 新手友好度 25/100
callstack/agent-device#3674 · 1 条评论 ·
维护者通常 1 天内回复
-
enhancement ready-for-agent
难度 5/5 一周以上 新手友好度 35/100
callstack/agent-device#3531 · 1 条评论 ·
维护者通常 1 天内回复
-
难度 4/5 1-2 天 新手友好度 55/100
callstack/agent-device#3449 · 1 条评论 ·
维护者通常 1 天内回复
查看 callstack/agent-device 的全部 Issue
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 68/100
apache/rocketmq-dashboard#6872 ·
维护者通常 3 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 70/100
fab-geocommuns/RNB-site#539 ·
维护者通常 2 天内回复
-
Guest multiview tile label leaks raw virtual-source-id "Whip" instead of the guest name / slot label未关闭
难度 2/5 1-3 小时 新手友好度 62/100
Eyevinn/open-live-studio#211 ·
维护者通常 1 天内回复
-
documentation good first issue
难度 2/5 半天 新手友好度 72/100
sujithputta02/Esapay#13 ·
-
难度 2/5 1-3 小时 新手友好度 65/100
ehmpathy/rhachet-roles-bhuild#468 ·
维护者通常 1 天内回复