Make Cache.Open return io.ReadSeekCloser to support Range requests
还没有人认领这个 Issue。
- #342 来自 @alecthomas —— 已关闭,未合并
评估
- 难度
- 5/5
- 预计耗时
- 一周以上
- 新手友好度
- 35/100
- Issue 类型
- 功能
- 描述清晰度
- 描述清楚
- 活跃度
- 冷清
- 技术栈
- go
- 领域
- api, backend, infrastructure, testing
调研方向
从 internal/cache/api.go 开始,跟踪 disk.go、memory.go、noop.go、s3.go 和 remote.go 中的 Open 实现,然后检查 httputil.ServeCacheHit 和分层缓存代码。先运行指定的 cache、S3、remote、ServeCacheHit、tiered 和 cachetest 测试;完成的标准是单范围响应和可 seek 读取在所有后端上都能工作,范围读取不会存储部分对象,并且 go test ./... 和仓库的 lint 目标均通过。
由索引模型根据 Issue 内容生成。
描述
Summary
Change the Cache interface so that Open() returns an io.ReadSeekCloser instead of an io.ReadCloser, in order to support HTTP Range requests when serving cached objects.
For most backends this is trivial. For backends that stream over the network (S3 and the Remote cache client), we introduce a wrapper that supports a single Seek() to set the start offset, followed by purely sequential reads, backed by a range request. The higher-level Range-serving code is written to use exactly this access pattern.
Interface change
In internal/cache/api.go, change:
Open(ctx context.Context, key Key) (io.ReadCloser, http.Header, error)
to return io.ReadSeekCloser. Document that callers serving ranges MUST use a single seek-to-start followed by sequential reads (no seek-to-end probing). Because io.ReadSeekCloser is a superset of io.ReadCloser, all existing sequential consumers (http.Fetch, git snapshot/bundle, gomod cacher, cachetest suite, etc.) continue to compile and work unchanged.
Shared seek helper
Add one reusable "seek-once, lazily open at offset, then sequential" wrapper implementing io.ReadSeekCloser, parameterised by an "open underlying stream at offset" function:
- Holds a pending start offset (default 0).
Seekis only meaningful before the firstRead: it sets the start offset, resolvingio.SeekStart/io.SeekCurrent/io.SeekEndagainst the known object size. After reading begins,Seekreturns an error.- On first
Read, lazily opens the underlying stream at the offset, then reads sequentially. Closetears down the underlying stream.
This helper is shared by the S3 and Remote backends (DRY).
Backend changes
- disk (
disk.go): return*os.Filedirectly — already anio.ReadSeekCloser. Signature only. - memory (
memory.go): wrap the existing*bytes.Reader(already seekable) in a no-op-close wrapper instead ofio.NopCloser. - noop (
noop.go): signature only (always returns a cache miss). - s3 (
s3.go): implement the helper's "open at offset" using the existingparallelGet/GetObjectpath, starting from the seek offset instead of 0. - remote (
remote.go+client/*.go): implement "open at offset" via a rangedGET. This requires:- a new
Range(start)RequestOptionin theclientpackage that setsRange: bytes=start-; client.Openaccepting206 Partial Contentin addition to200 OK.
- a new
Server-side Range support
Add single-range support to httputil.ServeCacheHit (shared by the API handler and the generic caching handler). Because the S3/Remote readers only support seek-to-start (not seek-to-end), parse the Range header manually rather than using http.ServeContent (which probes the end via Seek(0, io.SeekEnd)):
- Use the existing
Content-Lengthheader for the object size (no seek-to-end). - For a satisfiable single range:
Seek(start, io.SeekStart)once, thenio.CopyN, emitting206 Partial Content,Content-Range,Content-Length, andAccept-Ranges: bytes. - For an unsatisfiable range:
416 Range Not SatisfiablewithContent-Range: bytes */size. - No range / full request: behave as today (advertise
Accept-Ranges: bytes). - Preserve existing conditional (
If-Match/If-None-Match) handling.
This change powers both the API endpoint and, transitively, the Remote backend's ranged reads.
Tiered cache behaviour
The tiered backfill must not commit a truncated object when a range request reads only a slice.
- Full sequential read from a higher tier: keep today's free tee-backfill into tier 0 (no extra GET).
- Ranged read from a higher tier (a non-trivial
Seek): abandon the tee (cancel the tier-0 write so the partial entry is discarded) and kick off a singleton full copy — a background, request-independent (context.WithoutCancel) download of the whole object from the hitting tier into tier 0, deduplicated so N concurrent range readers trigger at most one copy. - A
bytes=0-whole-object range (Seek to current position 0 before any read) is treated as a no-op and keeps the cheap tee path.
Mechanics:
backfillReadCloserbecomes seekable and tracks bytes read.Seekto the current position before reading delegates to the source and keeps teeing; any otherSeekcancels the tee, fires the singleton-copy trigger once, then delegates the seek to the source.- Singleton copy dedup lives on
Tieredvia a shared*sync.Mapkeyed bynamespace + "/" + key. SinceTiered.Namespace()returns a fresh value per request, this map (and anamespacefield) must be carried throughNamespace()by pointer so dedup spans requests. - On trigger:
LoadOrStorethe key; if present, no-op. Otherwise spawn a goroutine that re-Opens the object from the hitting tier (full, unseeked read), writes it to tier 0 viaWriteFunc, and deletes the dedup entry on completion. Errors are logged, not returned (best-effort warming).
Consequence: a ranged read against a cold local tier causes two reads from the higher tier (the range plus the deduplicated background full copy). This is the cost of warming tier 0 on range access.
Tests
- S3 seekable reader: seek-then-sequential-read, error on seek-after-read.
ServeCacheHitranges:206+Content-Range,416unsatisfiable,Accept-Rangesadvertised, full request unchanged.- Remote range round-trip (client
Rangeoption +206handling end-to-end). - Tiered: ranged read does not commit a truncated tier-0 entry; ranged read triggers a (deduplicated) full singleton copy that warms tier 0; full read still tees as before.
- Add a Range case to the
cachetestsuite so every backend is exercised.
Validation
justtasks /go test ./...- linters (golangci-lint via the repo's
justtarget)
Out of scope / notes
- Multi-range (
multipart/byteranges) responses are not supported; only single ranges. - The "warm tier 0 on range access" copy is best-effort and fire-and-forget.
- 主要语言
- Go
- 星标
- 42
- 派生
- 15
- 平均合并
- 4 小时 23 分钟
- 30 天内合并 PR
- 3
环境准备
- 没有 Dockerfile 或 Docker Compose 文件
- 没有 Pull Request 模板
- 阅读贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
block/cachew 的其他 Issue
-
etag-range-followup
难度 2/5 1-3 小时 新手友好度 75/100
-
难度 5/5 一周以上 新手友好度 30/100
-
难度 5/5 一周以上 新手友好度 38/100
-
Avoid exposing Git credentials in subprocess command-line arguments可能已有人在做 @bcho 于 78 天前认领。 未关闭
难度 4/5 3-5 天 新手友好度 56/100
-
难度 5/5 一周以上 新手友好度 25/100
相似的 Issue
-
难度 2/5 1-3 小时 新手友好度 69/100
aws/amazon-ecs-agent#5177 ·
维护者通常 2 天内回复
-
release-followup
难度 2/5 1-3 小时 新手友好度 82/100
维护者通常 1 天内回复
-
kind/bug
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 76/100
apache/rocketmq-dashboard#7292 ·
维护者通常 3 天内回复
-
[Bug]: Deleting an MCP proxy leaves its API keys in the gateway's memory and in the policy engine未关闭Aspect/API Aspect/Other Severity/Minor Type/Bug
难度 2/5 1-3 小时 新手友好度 83/100
wso2/api-platform#3852 ·
维护者通常 1 天内回复