Injection vulnerability in ExIRC.Client.msg() / IRC standard nonconformance
还没有人认领这个 Issue。
评估
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 新手友好度
- 35/100
- Issue 类型
- 缺陷
- 描述清晰度
- 基本清楚
- 活跃度
- 停滞
- 技术栈
- elixir
- 领域
- networking, security
调研方向
从 ExIRC.Client.msg() 的实现和测试入手,该 issue 将其确定为存在漏洞的入口点。确定包含换行符的消息是如何处理的,然后验证 msg() 会拒绝这些消息,并验证提议的 msg_multiline() 行为会为每一行发送一条 IRC 消息。该 issue 未指定具体的文件或测试。
由索引模型根据 Issue 内容生成。
描述
I'll present this as a little story:
Suppose we are implementing a bot that reads the titles from Web pages and posts them on IRC, a classic.
As a short introduction (only vaguely related to the bug), further suppose that we are using Floki (which is also not standards conformant) to parse the title of say, this webpage:
<!DOCTYPE html>
<html><head><title>I don't want to
quit programming!</title></head><body>
…</body></html>
(this is conformant HTML, even though the formatting isn't pretty!)
Assume the result gets into title = "I don't want to\nquit programming!"… and we get to the ExIRC bug:
ExIRC.Client.msg(state.client, :privmsg, dest, "Title: #{title}")
In the IRC channel we see:
<someone> https://domain.tld/blog/i-dont-want-to-quit-programming
<potionbot> Title: I don't want to
*potionbot has quit ("programming!")
Oops.
Obvious solutions:
- Panicking: cut off all text after the first newline to prevent the injection.
- Vengeful: throw an error if there is a newline in the message (this is not legal in the IRC standard anyway).
- Posed: make the type of the fourth argument of
ExIRC.Client.msg()aStringWithoutNewlinestype, preventing the error at compile time. - Creative: post several messages in IRC, one per line.
My preference goes to the last two, and specifically both of them at once:
- Make
ExIRC.Client.msg()refuse newlines, preventing the application from starting if that's not guarded against, and - Introduce a new
ExIRC.Client.msg_multiline()method that posts several messages to accomodate for the line feeds.
For more ideas, see https://eiv.dev
- 主要语言
- Elixir
- 星标
- 154
- 派生
- 38
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南,环境需要你自己搭建:先看它的 README,通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
bitwalker/exirc 的其他 Issue
-
难度 5/5 一周以上 新手友好度 1/100
-
难度 3/5 1-2 天 新手友好度 42/100
-
难度 3/5 1-2 天 新手友好度 35/100
-
enhancement question
难度 5/5 一周以上 新手友好度 25/100
-
难度 4/5 3-5 天 新手友好度 35/100
相似的 Issue
-
Heavy legs 1.12–1.17: compiler corpus goldens not regenerated for #4770可能已有人在做 关联的 PR 仍在进行中或已合并。 未关闭
难度 2/5 1-3 小时 新手友好度 74/100
intellij-elixir/intellij-elixir#4782 ·
维护者通常 1 天内回复
-
bug
难度 2/5 1-3 小时 新手友好度 62/100
hexlet-codebattle/codebattle#2376 ·
-
level 2 wocs
难度 1/5 1 小时以内 新手友好度 90/100
phravins/QuantumBilling#51 ·
-
fix(ocr): compile the Tesseract-free pipeline with Tokio runtime可能已有人在做 @Goldziher 今天认领。 未关闭
难度 2/5 1-3 小时 新手友好度 78/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 70/100
carverauto/serviceradar#6898 ·
维护者通常 1 天内回复