breakpoints(): Better handling of time
@GreatEmerald 已经在做这个了。
开始于 2020年9月29日。
评估
这个 Issue 还没有评估数据。
描述
At the moment, the time attribute in breakpoints() gets lost most of the time, leading to output such as:
Optimal 2-segment partition:
Call:
breakpoints.matrix(X = X, y = y, h = h, breaks = breaks, hpc = hpc)
Breakpoints at observation number:
104
Corresponding to breakdates:
0.4521739
This is not useful, as the breakdates should actually tell you which year and day the break happened, rather than in which part of the time series it happened (that's already given by the observation number).
It works properly if the input is a ts object, since then datatsp is preserved. However, it is rare to run breakpoints() over a ts rather than a bfastpp() data.frame. The latter contains time as a column, which should then be preserved.
I propose to handle time better and different from the other covariates in X. If the input is ts, then decompose its input into year fractions as per bfastpp. If the input is a data.frame, make use of the time column. Add a time element to the result that holds the timestamps, either as POSIXct or year fractions.
This is a prerequisite to better plotting of breakpoints() diagnostics, as as it is it is impossible to plot the time series with correct labels, or to put the breakpoint at a particular time.
- 主要语言
- R
- 星标
- 6
- 派生
- 5
- PR 合并指标
- 30 天内没有已合并 PR
环境准备
这个项目没有提供开发容器、Dockerfile 或贡献指南，环境需要你自己搭建：先看它的 README，通用步骤见我们的新手贡献指南。
从这里开始
- 先读完整个 Issue，再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库，在一个分支上完成修改。
- 提交 Pull Request，并在描述里引用这个 Issue 编号。
bfast2/strucchangeRcpp 的其他 Issue
-
Tweak at the end未关闭question
难度 4/5 3-5 天 新手友好度 20/100
bfast2/strucchangeRcpp#38 · 1 条评论 ·
-
efp.matrix: implement lrvar and vcov parameters可能重新可做 @appelmar 于 2027 天前认领，目前没有进行中的 PR。 未关闭enhancement
bfast2/strucchangeRcpp#32 · 2 条评论 · 已指派 1 人 ·
-
bug help wanted
难度 5/5 一周以上 新手友好度 28/100
bfast2/strucchangeRcpp#22 · 2 条评论 ·
-
help wanted question
难度 5/5 一周以上 新手友好度 25/100
bfast2/strucchangeRcpp#20 · 1 条评论 ·
-
enhancement
难度 4/5 3-5 天 新手友好度 35/100
bfast2/strucchangeRcpp#16 ·
查看 bfast2/strucchangeRcpp 的全部 Issue
相似的 Issue
-
难度 1/5 1 小时以内 新手友好度 92/100
Open-Systems-Pharmacology/OSPSuite.ParameterIdentification#315 ·
-
难度 1/5 1 小时以内 新手友好度 88/100
维护者通常 1 天内回复
-
难度 2/5 1-3 小时 新手友好度 85/100
hubverse-org/hubUtils#307 ·
-
ai-authored model:claude-opus-5-5
难度 2/5 1-3 小时 新手友好度 76/100
-
bug ready
难度 2/5 1-3 小时 新手友好度 82/100
montilab/SigRepo_Server#144 ·
维护者通常 1 天内回复